Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump undici from 5.25.2 to 5.28.1 in /lib/workload/stateless/metadata_manager/src #69

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 29, 2023

Bumps undici from 5.25.2 to 5.28.1.

Release notes

Sourced from undici's releases.

v5.28.1

What's Changed

Full Changelog: nodejs/undici@v5.28.0...v5.28.1

v5.28.0

What's Changed

New Contributors

Full Changelog: nodejs/undici@v5.27.2...v5.28.0

v5.27.2

Full Changelog: nodejs/undici@v5.27.1...v5.27.2

v5.27.1

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [undici](https://github.com/nodejs/undici) from 5.25.2 to 5.28.1.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.25.2...v5.28.1)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 29, 2023
@brainstorm
Copy link
Member

@williamputraintan and others... I think that putting only the first 2 components of a semver version, i.e: 2.0 instead of 2.0.0 would avoid having dependabot on our backs constantly without much risk of breaking behavior as those minor bumps are supposed to be non-API breaking changes?

That's what me and @mmalenic do for most of our Rust crates... unfortunately Dependabot will pick it up from Cargo.lock anyway, but I reckon it's still easier to maintain with 2 version components instead of 3.... if possible/practical in TS.

@williamputraintan williamputraintan changed the base branch from main to mm-openapi January 19, 2024 00:59
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 19, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/lib/workload/stateless/metadata_manager/src/undici-5.28.1 branch January 19, 2024 01:00
@williamputraintan
Copy link
Member

Yeah agree, most of the package.json version has the caret version which allow until the next major release. But unfortunately, this PR is scanning through the lock files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants