Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(mm): Broken Comparison on Update #691

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

williamputraintan
Copy link
Member

The comparison is broken because the tracking sheet is all string and coverage is stored in float. It will then think this is always an update although the values are the same.

Fix #690

Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamputraintan williamputraintan merged commit c469621 into main Nov 13, 2024
6 checks passed
@williamputraintan williamputraintan deleted the fix(MM)/sync-put-events branch November 13, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata-manager: Multiple update event for every record
3 participants