Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(pipeline): Disable Dev Automatic Deployment #714

Merged
merged 4 commits into from
Nov 24, 2024

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Nov 22, 2024

Reshuffle the order of deployment: Automatic deployment to staging > manual to prod > manual to dev. Dev is still in the pipeline so that we can deploy changes with a button rather than cdk deploy locally.

@@ -16,5 +16,6 @@
]
},
"context": {
"@aws-cdk/core:suppressTemplateIndentation": true
Copy link
Member Author

@williamputraintan williamputraintan Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reduces the pipeline template by ~200KB. Currently, without we are sitting at ~800KB, so nearly there (limit is 1MB)

aws/aws-cdk#22529

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamputraintan williamputraintan merged commit 53b32d7 into main Nov 24, 2024
6 checks passed
@williamputraintan williamputraintan deleted the feat/disable-beta-auto-deploy branch November 24, 2024 22:24
@alexiswl
Copy link
Member

Thanks for this @williamputraintan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants