-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-migrate): data mover task #726
Conversation
106c227
to
94711c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Once you're ready @mmalenic these folders are the first batch to need archiving
|
Sure! I'll need someone to help me setup umccr/infrastructure#508 first. |
Alright, let do this before end of the week. @reisingerf @alexiswl Pls approve |
Ambitious. I think Marko still wanted to put an event notification at the end of the job |
Happy to do it without event notification, as it's not necessary for now? |
Huh, that's what I thought as Flo told me on last Wed. i.e. Event parts for later... Thought you guys catch up yesterday in office. Happy either way. |
Happy to progress tonight or next week, will merge after approval. |
I don't think we need the event part for now. First goal is to get the current BYOB data into the archive asap. Triggering via events may be useful for future automation. I am not sure about exit / completion events.... |
@mmalenic Marko, pls leave with us for the move. Flo and I will script it around your stepfunction and trigger them. Keep you posted. |
I'd run something like this. |
Build takes a while. Let run it in next week. |
Implements first task from #721
Changes
aws s3 sync
+aws s3 rm
to perform the move.Related to infrastructure PR umccr/infrastructure#508
Todo
ArchiveData
event to trigger the step function and publish aArchiveComplete
event back to the event bus.