filemanager: setup testing #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… making it consistent with PartialOrd
mmalenic
commented
Dec 13, 2023
| inner: ConfigLoader, | ||
| } | ||
|
|
||
| #[automock] |
There was a problem hiding this comment.
This creates an entirely new MockConfig struct which has methods that allow setting expectations.
| @@ -0,0 +1,246 @@ | |||
| #[double] | |||
There was a problem hiding this comment.
This expands to:
#[cfg(not(test))]
use crate::clients::aws::s3::Client;
#[cfg(test)]
use crate::clients::aws::s3::MockClient as Client;Which allows using different versions of the client in testing code compared to the main code.
brainstorm
approved these changes
Dec 14, 2023
|
Do you want to go for #74 first? There might be some conflicts. |
Ok, I'll put it up for review (now it's in draft), but there's still things left to fix :_S |
# Conflicts: # lib/workload/stateful/filemanager/Cargo.lock # lib/workload/stateful/filemanager/README.md # lib/workload/stateful/filemanager/filemanager-http-lambda/src/main.rs # lib/workload/stateful/filemanager/filemanager-ingest-lambda/Cargo.toml # lib/workload/stateful/filemanager/filemanager/src/events/aws/mod.rs # lib/workload/stateful/filemanager/filemanager/src/events/s3/collect.rs # lib/workload/stateful/filemanager/filemanager/src/events/s3/s3_client.rs
mmalenic
force-pushed
the
test/setup
branch
3 times, most recently
from
c342188 to
0aee1e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
Changes
It should be a lot easier to test locally now just by running
cargo test. This will mean that dev deployments are more likely to succeed if the tests pass locally. Now, if only there is way to removedocker compose upas well. Just being able to runcargo testdirectly would be the most convenient.