Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(SRM) models refatcor #753

Merged
merged 9 commits into from
Dec 5, 2024
Merged

Feat(SRM) models refatcor #753

merged 9 commits into from
Dec 5, 2024

Conversation

raylrui
Copy link
Contributor

@raylrui raylrui commented Dec 4, 2024

Feat(srm) models refactor

resolve #698, and #696

  1. add comment (annotation) to sequence run module
  2. add state module tp record sequence state change history (timeline)
  3. add column (v1pre3_id and ica_project_id and api_url) in Sequence for retrieve further details for icav2 bssh event
  4. change of 'SequenceRunStateChange' event registry, (id from "integer" to "string" as change of orcabus_id logic

new models will be:
image

emit 'SequenceRunStateChange' event

{
    "version": "0",
    "id": "abcdefgh-111-aaaa-e980-1a8d6dab96d1",
    "detail-type": "SequenceRunStateChange",
    "source": "orcabus.sequencerunmanager",
    "account": "44444444",
    "time": "2024-12-03T23:07:09Z",
    "region": "ap-southeast-2",
    "resources": [],
    "detail": {
        "id": "seq.1234ABCDEFG1234ABCD",
        "instrumentRunId": "222222_A01052_1234_BHVJJJJJJ",
        "runVolumeName": "bssh.123456789fabcdefghijkl",
        "runFolderPath": "",
        "runDataUri": "gds://bssh.123456789fabcdefghijkl",
        "sampleSheetName": "SampleSheet.V2.134567.csv",
        "startTime": "2024-11-08T00:10:13.0962060Z",
        "status": "STARTED"
    }
}

couple with OrcaUI PR umccr/orca-ui#91

@raylrui raylrui added the feature New feature label Dec 4, 2024
@raylrui raylrui self-assigned this Dec 4, 2024
@raylrui raylrui merged commit 2bcb605 into main Dec 5, 2024
6 checks passed
@raylrui raylrui deleted the feat/srm-models-refatcor branch December 5, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sequence-run-manager: allow comments on sequence run records
3 participants