Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(htsget): add htsget support #759

Merged
merged 3 commits into from
Dec 9, 2024
Merged

feat(htsget): add htsget support #759

merged 3 commits into from
Dec 9, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Dec 6, 2024

Closes #758

Changes

  • Enables htsget-rs support for all htsget-compatible filemanager files.
    • This reuses the filemanager-ingest-role to access files.
    • The htsget-rs endpoint can be queried using https://htsget-file.<stage>.umccr.org.

See related PR umccr/htsget-deploy#1

@mmalenic mmalenic self-assigned this Dec 6, 2024
@mmalenic mmalenic added feature New feature filemanager an issue relating to the filemanager labels Dec 6, 2024
victorskl
victorskl approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Minor typo to attend.

@mmalenic mmalenic merged commit 44532c3 into main Dec 9, 2024
6 checks passed
@mmalenic mmalenic deleted the feat/htsget branch December 9, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

@brainstorm brainstorm Awaiting requested review from brainstorm

Assignees

@mmalenic mmalenic

Labels
feature New feature filemanager an issue relating to the filemanager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add htsget support
2 participants
@mmalenic @victorskl