Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filemanager multiple same-key queries #762

Merged
merged 4 commits into from
Dec 9, 2024
Merged

feat: filemanager multiple same-key queries #762

merged 4 commits into from
Dec 9, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Dec 9, 2024

Closes #707

Changes

  • Adds explicit option to specify and or or conditions for multiple keys in the API.
    • By default or is used if omitted with key[]=..., like before.
    • Use key[or][]=... to explicitly request or joining, or key[and][]=... to explicitly request and joining. The extra [] is required.
  • General dependency bumps and OpenAPI generation update.

@mmalenic mmalenic self-assigned this Dec 9, 2024
@mmalenic mmalenic added feature New feature filemanager an issue relating to the filemanager labels Dec 9, 2024
victorskl
victorskl approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Let give this a go!

williamputraintan
williamputraintan approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@williamputraintan williamputraintan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalenic mmalenic merged commit 976909a into main Dec 9, 2024
6 checks passed
@mmalenic mmalenic deleted the fix/filemanager-mulitple-queries branch December 9, 2024 23:07
@williamputraintan williamputraintan mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamputraintan williamputraintan williamputraintan approved these changes

@victorskl victorskl victorskl approved these changes

@brainstorm brainstorm Awaiting requested review from brainstorm

Assignees

@mmalenic mmalenic

Labels
feature New feature filemanager an issue relating to the filemanager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filemanager: API should allow singular and list-based queries for the same key
3 participants
@mmalenic @victorskl @williamputraintan