Chore: Refactor Django orcabus_id
#784
Open
+510
−577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| operator.or_, (Q(**{"%s__iexact" % key: value}) | ||
| # Apparently the `get_prep_value` from the custom fields.py is not called prior hitting the Db but, | ||
| # the regular `__exact` still execute that function. | ||
| operator.or_, (Q(**{"%s__exact" % key: value}) |
There was a problem hiding this comment.
One caveat I found here is the strip/annotation will not work if it uses iexact ( on the custom filtering we had that based on model). Currently, changing it to filter for only exact match.
|
.. will review in tick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement custom Django custom-model-field for
orcabus_idto include prefixes.Resolve #766
The Django custom works well and could pass with or without the prefix. A function is called to sanitize the
orcabus_idbefore or after hitting the database.