Project setup refactor #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made the repo root is just the CDK TypeScript project * Refactored nested Makefile for how to call and run each toolchain app dependencies installation and test suite * Refactored Docker compose stack into each app inner dir app root and, made shared dir for common compose stack * Made GitHub Action PR Build to `make check` as pre-flight checkpoint before running main CI/CD automation CodePipeline * Offered common system-wide tools as Brewfile and allowed dev to choose any method fit to suit to set up local dev * Improved README.md and MICROSERVICE.md to reflect changes Python * Refactored Python requirements and Django setup into its own inner directory. Developer should not need to set up Python if they are not needed to * Refactored Django app to use PostgreSQL * Refactored Django app structure
* Added install system-wide tools dependencies as it gets refactored from the project root requirements-dev.txt to Brewfile
victorskl
requested review from
brainstorm,
andrewpatto,
mmalenic and
williamputraintan
victorskl
added
documentation
|
@reisingerf (I know you are away) and, @alexiswl @pdiakumis pls review too if you are able... This was based on long discussion during devops meeting some weeks ago..! |
|
No major red flags from me.. seems like a good idea to get this merged and people using it asap - and then iterate from there |
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolchain app dependencies installation and test suite
app root and, made shared dir for common compose stack
make checkas pre-flightcheckpoint before running main CI/CD automation CodePipeline
dev to choose any method fit to suit to set up local dev
Python
own inner directory. Developer should not need to set up
Python if they are not needed to