Update RDS Construct #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalenic
approved these changes
Jan 29, 2024
|
|
||
| const secret = new rds.DatabaseSecret(this, id + 'Secret', { | ||
| const dbSecret = new rds.DatabaseSecret(this, id + 'DbSecret', { |
There was a problem hiding this comment.
Is the idea that every microservice that needs the database will fetch this secret to connect?
There was a problem hiding this comment.
I am thinking this way but do you have any suggestion?
Realising this, I should have pass in the secret name so that it could be discovered by the microservice.
There was a problem hiding this comment.
I think this is okay. Probably simplest to just have one secret for the whole database cluster.
There was a problem hiding this comment.
Ha, I was thinking similarly for the DB stack to set up databases / users for the different services and isolate them against each other... but let's start simple ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly the switch from
mysqltopostgresRDS