refactor: filemanager deployment code and Makefile #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalenic
requested review from
williamputraintan,
victorskl,
brainstorm,
reisingerf and
andrewpatto
mmalenic
force-pushed
the
refactor/filemanager
branch
from
6a7034c to
463b10b
Compare
|
I will wait for rebase, Marko. Then, will review after one go... |
…ager # Conflicts: # lib/workload/stateful/database/component.ts # lib/workload/stateless/filemanager/README.md # lib/workload/stateless/filemanager/database/queries/ingester/aws/update_deleted.sql # lib/workload/stateless/filemanager/database/queries/ingester/aws/update_reordered_for_created.sql # lib/workload/stateless/filemanager/database/queries/ingester/aws/update_reordered_for_deleted.sql # lib/workload/stateless/filemanager/filemanager/src/events/aws/collector_builder.rs # test/stateful/databaseConstruct.test.ts
…groups and pre-compiled sqlx queries
mmalenic
force-pushed
the
refactor/filemanager
branch
from
9e675b2 to
360b2b3
Compare
mmalenic
commented
Feb 18, 2024
| @@ -0,0 +1,117 @@ | |||
| { | |||
There was a problem hiding this comment.
FYI, these query-*.json files are required for filemanager to compile without an active postgres database running, which means that any cdk synth doesn't need to know about the filemanager's docker compose configuration.
victorskl
reviewed
Feb 19, 2024
| ], | ||
| }, | ||
| }); | ||
| }); |
|
Thanks for the review @victorskl. I'll revert that SG change and also address the other recommendations. |
|
Sound good, no worries. |
…manager dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85.
No rush on this, I can merge after #92.
Changes
cdk_resource_invoke.tsgeneric over the type of Lambda function so that it can be used in other contexts and not just Rust functions.