Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies Update && Support Samplesheet V2 #34

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Dependencies Update && Support Samplesheet V2 #34

merged 6 commits into from
Dec 20, 2023

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Dec 19, 2023 •
edited
Loading

  • Update versions (cdk, node and their dependencies) along with fixes on the breaking changes
  • Support downloadable samplesheet v2

Deployed to: sscheck-dev

@williamputraintan williamputraintan marked this pull request as ready for review December 19, 2023 23:52
@williamputraintan
Copy link
Member Author

williamputraintan commented Dec 19, 2023 •
edited
Loading

Also need help here to cdk deploy the pipeline in prod account.

cd deploy
cdk deploy SSCheckFrontEndPipeline

@victorskl
Copy link
Member

Reviewing too

victorskl
victorskl approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸 If sscheck get more serious, we should improve a tab better when we have more time; but that's for next year.! Let ship it for now.

@williamputraintan williamputraintan merged commit 2a2599c into main Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

@reisingerf reisingerf Awaiting requested review from reisingerf

Assignees

@williamputraintan williamputraintan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamputraintan @victorskl