Merge branch 'main' into sai/rm_crisis

umee-network · Mar 26, 2024 · 4686af7 · 4686af7
2 parents 440334b + 41a826e
commit 4686af7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -52,8 +52,12 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### Improvements
 
+
 ### Bug Fixes
 
+- [2473](https://github.com/umee-network/umee/pull/2462) Correct x/ugov Amino registration for x/ugov messages (they don't have MessageName option).
+
+
 ## v6.4.0 - 2024-03-21
 
 ### Features

diff --git a/x/auction/codec.go b/x/auction/codec.go
@@ -22,7 +22,7 @@ func init() {
 	amino.Seal()
 }
 
-// RegisterLegacyAminoCodec registers the necessary x/uibc interfaces and
+// RegisterLegacyAminoCodec registers the necessary x/auction interfaces and
 // concrete types on the provided LegacyAmino codec. These types are used for
 // Amino JSON serialization.
 func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {

diff --git a/x/ugov/codec.go b/x/ugov/codec.go
@@ -1,8 +1,6 @@
 package ugov
 
 import (
-	"github.com/cosmos/gogoproto/proto"
-
 	"github.com/cosmos/cosmos-sdk/codec"
 	cdctypes "github.com/cosmos/cosmos-sdk/codec/types"
 	cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
@@ -26,11 +24,11 @@ func init() {
 	amino.Seal()
 }
 
-// RegisterLegacyAminoCodec registers the necessary x/uibc interfaces and
+// RegisterLegacyAminoCodec registers the necessary x/ugov interfaces and
 // concrete types on the provided LegacyAmino codec. These types are used for
 // Amino JSON serialization.
 func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
-	cdc.RegisterConcrete(&MsgGovUpdateMinGasPrice{}, proto.MessageName(&MsgGovUpdateMinGasPrice{}), nil)
+	cdc.RegisterConcrete(&MsgGovUpdateMinGasPrice{}, "umee/ugov/MsgGovUpdateMinGasPrice", nil)
 	cdc.RegisterConcrete(&MsgGovSetEmergencyGroup{}, "umee/ugov/MsgGovSetEmergencyGroup", nil)
 	cdc.RegisterConcrete(&MsgGovUpdateInflationParams{}, "umee/ugov/MsgGovUpdateInflationParams", nil)
 }