Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #37 - Fix build process and run for Carla Agent docker image #56

Conversation

MaxJa4
Copy link
Collaborator

@MaxJa4 MaxJa4 commented Nov 14, 2023

Description

This PR fixes the overall Carla Agent building process and uses the newest leaderboard-2.0 version:

  • Updated PythonAPI to the special leaderboard-2.0 v0.9.14-Version (hosted in this repo now as release)
  • Updated leaderboard + scenario-runner to latest leaderboard-2.0 version
  • Small bugfixes and improvements to Agent-Dockerfile
  • Rebuilt Carla Simulator to use the newest leaderboard-2.0 version (located here) -> also 8GB smaller now
  • Fixed linter error messages on b5 run
  • Fixed ALSA error messages from Unreal-Engine on b5 run

--> Building and running works again with the newest updates for leaderboard-2.0!

Be aware, that the current implementation (PAF22) is broken! The agent doesn't leave its parking spot at the beginning, probably because there's a lot more traffic now.

The rebuilt Carla Simulator Docker image was downloaded from here and then built with the included Dockerfile.

Fixes #37 #76

Authors: @samuelkuehnel @MaxJa4

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Does this PR introduce a breaking change?

No, it fixes

Most important changes

Newest leaderboard-2.0 files and working agent docker build & run.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

This comment was marked as off-topic.

@MaxJa4 MaxJa4 marked this pull request as draft November 15, 2023 11:21
@MaxJa4
Copy link
Collaborator Author

MaxJa4 commented Nov 16, 2023

@ll7 @JulianTrommer There is a new CARLA simulator version for Leaderboard-2.0 available (the one from ghcr.io/nylser/carla:leaderboard is from Oct. 22) and needs to be updated along with the PythonAPI (its from the same image and should match). Also saves ~8GB of image space.

For now, I uploaded it to my Docker repo finalend4/paf23:leaderboard-2.0, but it would be best to upload it here in this repo. I can't do it myself as the repo's GitHub Token is needed.

FYI: The new leaderboard simulator version comes with a few breaking changes, one of which: a lot more traffic. Will document that in this PR after everything is done here.

cc @samuelkuehnel

@ll7 ll7 self-assigned this Nov 16, 2023
@ll7
Copy link
Member

ll7 commented Nov 16, 2023

I am currently working on pushing the image. I will notify you as soon as the image is online.

build/docker/agent/Dockerfile Outdated Show resolved Hide resolved
@ll7
Copy link
Member

ll7 commented Nov 16, 2023

The package is now online: https://github.com/una-auxme/paf23/pkgs/container/paf23/148387355?tag=leaderboard-2.0

Copy link

Simulation results

Metric Value
Avg. driving score 0.005892
Avg. route completion 0.02
Avg. infraction penalty 0.348058
Collisions with pedestrians 0.0
Collisions with vehicles 0.0
Collisions with layout 709.196
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0.001
Route deviations 0.0
Route timeouts 709.196
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 709.196
Min speed infractions 0.0

@MaxJa4 MaxJa4 marked this pull request as ready for review November 18, 2023 15:45
@MaxJa4 MaxJa4 requested review from ll7 and removed request for JulianTrommer November 18, 2023 15:45
@MaxJa4 MaxJa4 added the infrastructure Docker, Project setup, ... label Nov 18, 2023
@MaxJa4
Copy link
Collaborator Author

MaxJa4 commented Nov 22, 2023

This PR is currently blocked by #76 and also waits for merging of #88 (hence the failing CI of 7a3129f).

Do not merge (yet)

@MaxJa4 MaxJa4 added the blocked label Nov 22, 2023
@MaxJa4
Copy link
Collaborator Author

MaxJa4 commented Nov 27, 2023

The non-driving agent is fixed with 603011e.
After #88 is merged, this PR is ready for merging as well.

@MaxJa4 MaxJa4 removed the blocked label Nov 27, 2023
@MaxJa4
Copy link
Collaborator Author

MaxJa4 commented Nov 27, 2023

TODO: Rebase to current main

Done!

@MaxJa4 MaxJa4 force-pushed the 37-bug-update-docker-image-for-carla-simulator-to-fix-build-process branch from f047678 to e129882 Compare November 27, 2023 17:48
@MaxJa4 MaxJa4 unassigned ll7 Nov 27, 2023
@MaxJa4 MaxJa4 removed the request for review from ll7 November 27, 2023 17:54
Copy link

Simulation results

Metric Value
Avg. driving score 0.0
Avg. route completion 0.0
Avg. infraction penalty 0.7
Collisions with pedestrians 0.0
Collisions with vehicles 0.0
Collisions with layout 0.0
Red lights infractions 0.0
Stop sign infractions 0.0
Off-road infractions 0
Route deviations 0.0
Route timeouts 2000.0
Agent blocked 0.0
Yield emergency vehicles infractions 0.0
Scenario timeouts 2000.0
Min speed infractions 0.0

Copy link
Collaborator

@samuelkuehnel samuelkuehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work!

@MaxJa4 MaxJa4 merged commit 7d1d625 into main Nov 28, 2023
3 checks passed
@MaxJa4 MaxJa4 deleted the 37-bug-update-docker-image-for-carla-simulator-to-fix-build-process branch November 28, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Docker, Project setup, ...
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Update Docker Image for Carla Simulator to Fix Build Process
3 participants