Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Update Docker Image for Carla Simulator to Fix Build Process #37

Closed
ll7 opened this issue Nov 13, 2023 · 1 comment · Fixed by #56
Closed

[Bug]: Update Docker Image for Carla Simulator to Fix Build Process #37

ll7 opened this issue Nov 13, 2023 · 1 comment · Fixed by #56
Assignees
Labels
blocked bug Something isn't working

Comments

@ll7
Copy link
Member

ll7 commented Nov 13, 2023

Current Behavior

6e8f85d

Description:
We are currently using on outdated versions of the Carla simulator. Our project is using specific commits from the scenario_runner and leaderboard repositories, which are not compatible with the latest versions of these tools. This problem stems from relying on an outdated Carla simulator version provided by @nylser in his Docker registry.

Details:

Current Approach: The build process uses old commits from scenario_runner and leaderboard repositories to maintain compatibility with the outdated Carla simulator.
Issue Source: The root of the problem is the outdated version of the Carla simulator in the Docker image provided by @nylser.

Proposed Solution:

Create an Updated Docker Image:
Develop a new Docker image that includes the up-to-date Carla simulator files, as available on the leaderboard website.

Update Repository Branches:
Once the Docker image is updated, align the scenario_runner and leaderboard repository branches with the latest versions.

Thorough Testing:
Conduct comprehensive tests of the entire setup after updating the Docker image and repository branches to ensure stability and compatibility.

Expected Outcome:
Updating the Docker image and aligning our repository branches with the latest versions should resolve the build issues and improve the overall stability and functionality of our project.

Expected Behavior

No response

How to reproduce the issue

No response

@ll7 ll7 added bug Something isn't working help wanted Extra attention is needed labels Nov 13, 2023
@ll7
Copy link
Member Author

ll7 commented Nov 13, 2023

#38 could be related.

MaxJa4 added a commit that referenced this issue Nov 14, 2023
@MaxJa4 MaxJa4 linked a pull request Nov 14, 2023 that will close this issue
5 tasks
@MaxJa4 MaxJa4 added blocked and removed help wanted Extra attention is needed labels Nov 22, 2023
MaxJa4 added a commit that referenced this issue Nov 27, 2023
MaxJa4 added a commit that referenced this issue Nov 28, 2023
* Leaderboard and Szenariorunner version changed

* PythonAPI v0.9.14 added to dockerfile

* fix(#37): Fix agent image building

* fix(#37): Updated carla simulator to newest leaderboard-2.0 version

* fix(#37): Fix simulator ALSA warnings and linter errors

* fix: fixed Coordinates in Town 12 and
added new dockerfile for submission.
(Not adjusted yet)

* Remove workaround as its no longer needed after #88

* Remove to have a sperate PR

---------

Co-authored-by: samuelkuehnel <[email protected]>
Co-authored-by: samuelkuehnel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants