Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Restructure docker-compose files & Removed b5 run tasks #276

Conversation

ll7
Copy link
Member

@ll7 ll7 commented Aug 20, 2024

Description

use the docker extend command to reuse code snippets

Fixes #267

Type of change

docker-compose file update and fewer changes per file

Does this PR introduce a breaking change?

likely, the CI/CD will not work any longer. We will need to fix this in a future PR.

@ll7 ll7 requested a review from JulianTrommer August 20, 2024 07:24
@ll7 ll7 linked an issue Aug 20, 2024 that may be closed by this pull request
@una-auxme una-auxme deleted a comment from github-actions bot Aug 22, 2024
Copy link

Simulation results

Metric Value
Avg. driving score 0.00011
Avg. route completion 37.465
Avg. infraction penalty 1.1e-05
Collisions with pedestrians 1.016
Collisions with vehicles 14.058
Collisions with layout 5.081
Red lights infractions 0.0
Stop sign infractions 0.169
Off-road infractions 0.147
Route deviations 0.0
Route timeouts 0.0
Agent blocked 0.339
Yield emergency vehicles infractions 0.0
Scenario timeouts 0.169
Min speed infractions 0.0

Copy link
Member

@JulianTrommer JulianTrommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding PR Lennart!

@JulianTrommer JulianTrommer merged commit 4efecd3 into main Aug 29, 2024
3 checks passed
@JulianTrommer JulianTrommer deleted the 267-instead-of-using-four-distinct-docker-compose-files-use-extends branch August 29, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instead of using four distinct docker-compose files, use extends
2 participants