-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added documentation for datasource v1 and v2 #71
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see the images on the preview
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
umh.docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource.md
Outdated
Show resolved
Hide resolved
umh.docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource.md
Outdated
Show resolved
Hide resolved
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
umh.docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource.md
Outdated
Show resolved
Hide resolved
umh.docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource.md
Outdated
Show resolved
Hide resolved
...ocs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/factoryinput-panel.md
Outdated
Show resolved
Hide resolved
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
Create an archetype for the grafana-plugins:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis would also the best place to actual explain the capabilities of the datasource, so to go through each slider, etc. and explain what it does. What does Time Bucket do? What does configuration do? etc.
…_v2' into feat/52/grafanaplugin_datasource_v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still can't see the pictures from the CloudFlare preview
...ocs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/factoryinput-panel.md
Show resolved
Hide resolved
umh.docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource.md
Outdated
Show resolved
Hide resolved
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
…_v2' into feat/52/grafanaplugin_datasource_v2
…_v2' into feat/52/grafanaplugin_datasource_v2
…_v2' into feat/52/grafanaplugin_datasource_v2
Check out also this code here:
|
And check out this:
|
Since the query options are not available for every value to query, it should be explicitly indicated which options are available for which values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the correct formatting style.
- Each line should not be longer than 80 characters. You can set a vertical line in your text editor to help you with that. Depending on the editor you use, the setting might be called ruler, right margin, or column
- Use a markdown linter. For example, in VS code there is an extension called markdownlint that will show you common style errors, like not having a blank line before and after a code block
``` ... ```
Lastly, remember to squash the commits before merging. Here more info about that. Ask me for help if you have doubts
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
umh.docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource.md
Outdated
Show resolved
Hide resolved
...ocs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/factoryinput-panel.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the correct formatting style.
- Each line should not be longer than 80 characters. You can set a vertical line in your text editor to help you with that. Depending on the editor you use, the setting might be called ruler, right margin, or column
- Use a markdown linter. For example, in VS code there is an extension called markdownlint that will show you common style errors, like not having a blank line before and after a code block
``` ... ```
Lastly, remember to squash the commits before merging. Here more info about that. Ask me for help if you have doubts
...docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to solve the merge conflicts and to squash the commits afterwards (we follow the conventional commits style)
Other than that, LGTM
…_datasource_v2 # Conflicts: # umh.docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource-v2.md # umh.docs.umh.app/content/en/docs/architecture/microservices/grafana-plugins/umh-datasource.md
feat #52