Updatingv2 #23
Merged
Updatingv2 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- localClientActive to above active - ActivateHostScene to bottom out of the way
- Nothing in NetworkIdentity calls this, only external callers
- AssignClientAuthority is the only caller in this class
…anymore (MirrorNetworking#3339) * Fixes: MirrorNetworking#3326 - All callers to Reset are either unspawning (disabling) the object or have run a custom UnSpawnHandler - Sync collections should retain their data in any case because the object may get respawned - When it is respawned, OnDeserializeAll clears the internal collection and changes lists before adding back the entire payload. - Users can always call the public Reset on the SyncObject themselves if they want it wiped. * fixed comment
…issions fixed for host mode and other player's objects on client
…wned objects like character previews
…ivates, but does not spawn scene objects with inactive parents (MirrorNetworking#3347) * fix: MirrorNetworking#3330 MirrorNetworking#2422 SpawnObjects now activates, but does not spawn scene objects with inactive parents * helper function * remove old workaround. identities which aren't active in hierarchy don't have Awake called forcefully anymore. it's not necessary because the second pass won't spawn them anymore. * add comments
- avoids NRE flood if no camera with MainCamera tag.
* Update activation.ylm * Added Semantic.yml * Added SonarQube.yml * Updated main.yml * Updated main.yml * SonarQube - container fixed * main.yml - disabled SonarQube for now - That's going to need a bit more work.
… value in OnSerialize - Fixes MirrorNetworking#3349
- perf: KcpServer/Client RawReceive now call socket.Poll to avoid non-blocking socket's allocating a new SocketException in case they WouldBlock. fixes MirrorNetworking#3413 - perf: KcpServer/Client RawSend now call socket.Poll to avoid non-blocking socket's allocating a new SocketException in case they WouldBlock. fixes MirrorNetworking#3413
- Send/SendTo/Receive/ReceiveFrom NonBlocking extensions. to encapsulate WouldBlock allocations, exceptions, etc. allows for reuse when overwriting KcpServer/Client (i.e. for relays).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.