[Material][TextBox] Make all property values on Setters from VisualStates accessible via ThemeResources

[ADD-Noureddine-Maachi]

What would you like to be added:

ThemeResources for property values that are currently set directly to Setters in VisualStates.

Uno.Themes/src/library/Uno.Material/Styles/Controls/v2/TextBox.xaml

Lines 679 to 688 in 569a9c0

	<VisualState x:Name="PointerOver">
	<VisualState.Setters>
	<Setter Target="RootBorder.BorderBrush" Value="{ThemeResource OutlinedTextBoxBorderBrushPointerOver}" />
	<Setter Target="ContentElement.Foreground" Value="{ThemeResource OutlinedTextBoxForegroundPointerOver}" />
	<Setter Target="PlaceholderElement.Foreground" Value="{ThemeResource OutlinedTextBoxPlaceholderForegroundPointerOver}" />
	<Setter Target="HeaderElement.Foreground" Value="{ThemeResource OutlinedTextBoxHeaderForegroundPointerOver}" />
	<Setter Target="RootBorder.BorderThickness" Value="2" />
	<Setter Target="RootBorder.Padding" Value="0" />
	</VisualState.Setters>
	</VisualState>

As you can see, the properties RootBorder.BorderThickness and RootBorder.Padding have no ThemeResources like the other Setters.

Why is this needed:

It would be very useful since this way you can easily customize the style referring to the key of the ThemeResource. It would not be convenient to modify the setters in any other way.

Anything else we need to know?

I am having this problem with the Style MaterialOutlinedTextBoxStyle.

[ADD-Noureddine-Maachi]

Besides that, we have found that the behavior of the MinHeight property is not working correctly.

A default Material TextBox with the Style MaterialOutlinedTextBoxStyle has the following values:

We understand that the ActualHeight should also be 56. Is there any element in the Template that is affecting to the TextBox height?

Thanks in advance.

Update

We have found a workaround for now, maybe it can give you some clue or the solution itself.

The workaround is about setting the Height from 38 to 36 to all elements inside the Grid named "Root" (except the ScrollViewer) and changing the ScrollViewer padding from 0,10 to 0,7.

[kazo0]

FYI @agneszitte as I know we had worked on fiddling with these numbers previously

[agneszitte]

Hi @ADD-Noureddine-Maachi

The fixes are now available with the latest dev build of Uno Themes, but they haven’t yet been released in a stable version of uno.sdk. We’ll need to conduct additional QA to ensure these changes don’t introduce any regressions.

In the meantime, you can already test the latest fixes by overriding the Uno Themes version specifically (alongside the latest stable uno.sdk version you're currently using). To do so, add the following to your Directory.Build.props file:

<PropertyGroup>
    <UnoThemesVersion>5.4.0-dev.18</UnoThemesVersion>
</PropertyGroup>

Warning

Please remember to remove this override when it’s no longer necessary, once the fixes are included in a stable release of uno.sdk.

Here are the details of the related changes to the Resource Keys with the latest updates:
Material Migration Guide - Upgrading to Uno Themes v-next

Please feel free to reach out to us with any additional feedback as needed.