Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Material" Prefix from TextBox Styles #1495

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

Kunal22shah
Copy link
Contributor

GitHub Issue: #1469 #1491 (comment)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1495.eastus2.azurestaticapps.net

BREAKING CHANGE: This commit removes the "Material" prefix from all TextBox-related styles and resources
@Kunal22shah Kunal22shah force-pushed the dev/ks/renaming-textbox-styles branch from dad2433 to b5b04c5 Compare October 28, 2024 20:09
@Kunal22shah Kunal22shah changed the title Breaking Change: Remove "Material" Prefix from TextBox Styles Remove "Material" Prefix from TextBox Styles Oct 28, 2024
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1495.eastus2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1495.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 self-requested a review October 30, 2024 17:53
doc/material-migration.md Outdated Show resolved Hide resolved
doc/material-migration.md Outdated Show resolved Hide resolved
Co-authored-by: Xiaotian Gu <[email protected]>
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1495.eastus2.azurestaticapps.net

@Kunal22shah Kunal22shah enabled auto-merge October 30, 2024 18:06
@Kunal22shah Kunal22shah merged commit a81d814 into master Oct 30, 2024
20 checks passed
@Kunal22shah Kunal22shah deleted the dev/ks/renaming-textbox-styles branch October 30, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Material][TextBox] Make all property values on Setters from VisualStates accessible via ThemeResources
3 participants