Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Navigation View theme fixes #1360

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: Navigation View theme fixes #1360

merged 1 commit into from
Apr 12, 2024

Conversation

silviuo
Copy link
Contributor

@silviuo silviuo commented Feb 20, 2024

GitHub Issue: closes #1219

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

Navigation View

Figma

Changes made based on latest design

  • colors, fonts, label visibility, pane padding, content radius, item disabled state, item selection in compact mode

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@silviuo silviuo requested a review from kazo0 February 20, 2024 16:33
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1360.eastus2.azurestaticapps.net

@kazo0
Copy link
Collaborator

kazo0 commented Feb 20, 2024

fyi @iurycarlos

Copy link
Collaborator

@kazo0 kazo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1360.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 self-requested a review February 22, 2024 15:41
- colors, fonts

fix: Navigation View theme fixes

- label visibility, pane padding, content radius, item disabled state

fix: Navigation View theme fixes

- Item selection in compact mode

fix: Navigation View theme fixes

- updated md file
@kazo0 kazo0 force-pushed the dev/siob/navview branch from 1258d17 to 9746cc5 Compare April 12, 2024 13:59
@kazo0 kazo0 enabled auto-merge (squash) April 12, 2024 14:01
@kazo0
Copy link
Collaborator

kazo0 commented Apr 12, 2024

@Mergifyio backport release/stable/5.0

Copy link

mergify bot commented Apr 12, 2024

backport release/stable/5.0

✅ Backports have been created

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1360.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 733836e into master Apr 12, 2024
20 checks passed
@kazo0 kazo0 deleted the dev/siob/navview branch April 12, 2024 14:32
mergify bot pushed a commit that referenced this pull request Apr 12, 2024
- colors, fonts

fix: Navigation View theme fixes

- label visibility, pane padding, content radius, item disabled state

fix: Navigation View theme fixes

- Item selection in compact mode

fix: Navigation View theme fixes

- updated md file

(cherry picked from commit 733836e)
mergify bot pushed a commit that referenced this pull request Apr 12, 2024
- colors, fonts

fix: Navigation View theme fixes

- label visibility, pane padding, content radius, item disabled state

fix: Navigation View theme fixes

- Item selection in compact mode

fix: Navigation View theme fixes

- updated md file

(cherry picked from commit 733836e)
mergify bot pushed a commit that referenced this pull request Apr 12, 2024
- colors, fonts

fix: Navigation View theme fixes

- label visibility, pane padding, content radius, item disabled state

fix: Navigation View theme fixes

- Item selection in compact mode

fix: Navigation View theme fixes

- updated md file

(cherry picked from commit 733836e)
agneszitte added a commit that referenced this pull request Apr 23, 2024
….0/pr-1360

fix: Navigation View theme fixes (backport #1360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationView colors different from FigmaFile
2 participants