fix: Navigation View theme fixes (backport #1360) #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
- colors, fonts fix: Navigation View theme fixes - label visibility, pane padding, content radius, item disabled state fix: Navigation View theme fixes - Item selection in compact mode fix: Navigation View theme fixes - updated md file (cherry picked from commit 733836e)
12 tasks
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1389.eastus2.azurestaticapps.net |
|
@kazo0 note to self, merge next week |
When will be the best time to merge this one lately @kazo0 / @jeromelaban ? |
After 5.2 @kazo0, @jeromelaban said |
|
@jeromelaban would it be a good time now to merge this one? |
|
@agneszitte It is, yes. We can backport when needed. |
agneszitte
approved these changes
Apr 23, 2024
@jeromelaban, @kazo0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes #1219
PR Type
What kind of change does this PR introduce?
Description
Figma
Changes made based on latest design
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):
This is an automatic backport of pull request #1360 done by [Mergify](https://mergify.com).