Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable C# HR on iOS/Catalyst, use XAML Reader instead (backport #15919) #15940

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 19, 2024

GitHub Issue (If applicable): #15918

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):


This is an automatic backport of pull request #15919 done by [Mergify](https://mergify.com).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15940/index.html

@jeromelaban jeromelaban enabled auto-merge March 19, 2024 15:27
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15940/index.html

@nventive-devops
Copy link
Contributor

The build 117141 found UI Test snapshots differences: android-28-net7: 0, android-28-net7-Snap: 46, ios: 110, ios-Snap: 641, skia-gtk-screenshots: 19, skia-wpf-screenshots: 20, wasm: 24, wasm-automated-net7.0-UWP-Default-automated: 47, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 1, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details
  • android-28-net7: 0 changed over 1

  • android-28-net7-Snap: 46 changed over 1049

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_HorizontalListView_Padding_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Padding
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
    • ListView_ListViewWithinScollViewer_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewWithinScollViewer
    • ListView_UndefinedHeightListView_SamplesApp_Windows_UI_Xaml_Controls_ListView_UndefinedHeightListView
    • LoopingSelector_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Items_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Items
    • LoopingSelector_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Short_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Short
    • Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • NavigationView_FluentStyle_NavigationViewSample_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • ListView_ScrollIntoViewTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_ScrollIntoViewTest
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons
    • TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_In_ContentDialog_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_In_ContentDialog
    • TextBox_Uno_UI_Samples_UITests_TextBoxControl_TextBox_IsReadOnly_Uno_UI_Samples_UITests_TextBoxControl_TextBox_IsReadOnly
    • NavigationView_MUXControlsTestApp_NavigationViewAnimationPage_MUXControlsTestApp_NavigationViewAnimationPage
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
  • ios: 110 changed over 266

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Button_NestedButtons_Validation_nVentive_Umbrella_Views_UI_Samples_Content_UITests_ButtonTestsControl_Nested_Buttons
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • Flyout_ShowAt_Window_Content_UITests_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_ShowAt_Window_Content
    • DatePicker_Flyout_DatePicker_-_Flyout
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State
    • ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
    • ListView_ExpandableItem_ExpandMultipleItems_Expanded_State
    • ListView_ObservableCollection_Creation_Count_Added
    • ListView_ObservableCollection_Creation_Count_UITests_Windows_UI_Xaml_Controls_ListView_ListView_ObservableCollection_CreationCount
    • ListView_Weird_Measure_During_Arrange_after_layout
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TextBox_Disable_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Disabled
    • StaticResource_Converter_Validation_UITests_Shared_Resources_StaticResource_StaticResource_Simple
    • ToggleButton_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ToggleButton_IsEnabled_Automated
    • ToggleSwitch_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ToggleSwitch_IsEnable_Automated
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ListView_ChangingText_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
    • ListView_ExpandableItem_ExpandMultipleItems_Collapsed_State
    • ListView_ObservableCollection_Creation_Count_Scrolled2
  • ios-Snap: 641 changed over 1040

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage
    • AutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Icons_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Icons
    • Border_BorderTopwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderTopwithmargins
    • Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_Changed_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_Changed
    • Buttons_AppBarButtonTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarButtonTest
    • Buttons_AppBarButtonWithIconTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarButtonWithIconTest
    • ContentControl_ContentControl_MultiLevelInheritance_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_MultiLevelInheritance
    • ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
    • Default_UITests_Toolkit_ElevatedView_Corners_UITests_Toolkit_ElevatedView_Corners
    • Default_UITests_Toolkit_ElevatedView_Dimensions_UITests_Toolkit_ElevatedView_Dimensions
    • FrameworkElement_UnloadedMeasure_UITests_Shared_Windows_UI_Xaml_FrameworkElementTests_FrameworkElement_UnloadedMeasure
    • GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewGroupedResizable_Uno_UI_Samples_Content_UITests_GridView_GridViewGroupedResizable
    • Image_ImageSourceFileUri_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceFileUri
    • Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
    • Image_ImageSourceUrlMsAppxScheme_Uno_UI_Samples_UITests_ImageTests_ImageSourceUrlMsAppxScheme
    • Image_ImageSourceUrlNoScheme_Uno_UI_Samples_UITests_ImageTests_ImageSourceUrlNoScheme
    • ListView_ListViewDynamicOrientation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewDynamicOrientation
    • ListView_ListViewEmptyGroups_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewEmptyGroups
    • ListView_ListViewStackPanel_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewStackPanel
    • ListView_ListViewVariableHeightButton_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewVariableHeightButton
  • skia-gtk-screenshots: 19 changed over 1098

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • WinUI-PipsPagerExamples.png
    • MUX-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_Features.png
    • Image-Image_Stretch_None_ScrollViewer.png
    • MediaPlayerElement-Using .avi.png
    • ListView-ListViewSelectedItems.png
    • Progress-WindowsProgressRing_GH1220.png
    • Microsoft.UI.Composition-CompositionVisualSurface.png
    • MediaPlayerElement-Using .3gp.png
    • Progress-ProgressRingHeightTest.png
    • Pickers-CalendarView_Theming.png
    • MediaPlayerElement-Using .mp3 (Audio only).png
    • Microsoft.UI.Composition-CompositionMaskBrush.png
    • Microsoft.UI.Composition-RedirectVisual.png
    • Image-Image_Formats.png
    • MUX-WinUIProgressRing_CustomSources.png
    • PipsPager-PipsPagerExamples.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
  • skia-wpf-screenshots: 20 changed over 1098

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Brushes-ImageBrush_StreamSource.png
    • MediaPlayerElement-Mini player.png
    • Microsoft.UI.Composition-CompositionVisualSurface.png
    • Microsoft.UI.Composition-RedirectVisual.png
    • DragAndDrop-DragDrop_TestPage.png
    • PipsPager-PipsPagerExamples.png
    • ListView-ListViewSelectedItems.png
    • Automation-AutomationProperties_Name.png
    • Microsoft.UI.Composition-CompositionMaskBrush.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Pickers-CalendarView_Theming.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WindowsProgressRing_GH1220.png
    • Image-UniformToFill100x100.png
    • Transform-TransformToVisual_Translate2d.png
    • WinUI-PipsPagerExamples.png
  • wasm: 24 changed over 1045

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.PaneLayoutTestPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • UITests.Microsoft_UI_Xaml_Controls.ProgressBar.WinUIProgressBarSimple
    • UITests.Windows_Media.MediaPlayerTests
    • SamplesApp.Samples.NavigationViewSample.NavigationViewSample
    • UITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPage
    • UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Avi_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Flv_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal
    • MUXControlsTestApp.NavigationViewCompactPaneLengthTestPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.ProgressRingHeightTest
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mkv_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mov_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mp3_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Ogg_Extension
    • UITests.Windows_UI_Xaml_Controls.CalendarView.CalendarView_Theming
  • wasm-automated-net7.0-UWP-Default-automated: 47 changed over 1948

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
    • ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
    • ContentDialog_Simple_NotLightDismissible_1_ContentDialog_Opened
    • ListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • ListView_ListView_Expandable_Item_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item
    • Check_ListView_Swallows_Measure_after_scroll
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LinearGradientBrush_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LinearGradientBrush
    • Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_FillRule_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_FillRule
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry
  • wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-1: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage
  • wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-2: 0 changed over 1

@jeromelaban jeromelaban merged commit 3a89554 into release/stable/5.1 Mar 19, 2024
91 of 92 checks passed
@jeromelaban jeromelaban deleted the mergify/bp/release/stable/5.1/pr-15919 branch March 19, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants