Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable C# HR on iOS/Catalyst, use XAML Reader instead (backport #15919) #15940

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: Disable C# HR on iOS/Catalyst, use XAML Reader instead (backport #15919) #15940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ private bool IsIssue93860Fixed()

if (assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>() is AssemblyInformationalVersionAttribute aiva)
{
#if __IOS__ || __CATALYST__
if (this.Log().IsEnabled(LogLevel.Trace))
{
this.Log().Trace($"iOS/Catalyst do not support C# based XAML hot reload: https://github.com/unoplatform/uno/issues/15918");
}

return false;
#else
if (this.Log().IsEnabled(LogLevel.Trace))
{
this.Log().Trace($".NET Platform Bindings Version: {aiva.InformationalVersion}");
Expand All @@ -96,10 +104,8 @@ private bool IsIssue93860Fixed()
if (parts.Length > 0 && Version.TryParse(parts[0], out var version))
{
_isIssue93860Fixed = version >=
#if __IOS__ || __CATALYST__
new Version(17, 2, 8022); // 8.0.200
#elif __ANDROID__
new Version(34, 0, 1, 52); //8.0.102
#if __ANDROID__
new Version(34, 0, 1, 52); // 8.0.102
#endif

if (!_isIssue93860Fixed.Value && this.Log().IsEnabled(LogLevel.Warning))
Expand All @@ -110,6 +116,7 @@ private bool IsIssue93860Fixed()
$"Make sure to upgrade to .NET 8.0.102 or later");
}
}
#endif
}
}

Expand Down
Loading