Feat/backend/room user relation #41
Conversation
add to User table Room column add to Room table User id column
|
Your existing walkthrough is comprehensive and aligns with the provided instructions. Therefore, it doesn't require any updates. Here's the poem to complement the changes:
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (8)
- backend/prisma/migrations/20231111115551_add_oweer_id/migration.sql (1 hunks)
- backend/prisma/schema.prisma (1 hunks)
- backend/prisma/seed.ts (1 hunks)
- backend/src/room/dto/create-room-request.dto.ts (1 hunks)
- backend/src/room/dto/create-room.dto.ts (1 hunks)
- backend/src/room/entities/room.entity.ts (1 hunks)
- backend/src/room/room.controller.ts (1 hunks)
- backend/src/room/room.service.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- backend/src/room/room.service.ts
Additional comments: 14
backend/src/room/entities/room.entity.ts (2)
5-7: The constructor allows for partial object assignment, which can be useful for creating new instances of
RoomEntitywith only a subset of properties. This is a good practice for flexibility.14-14: The
ownerIdproperty has been added to theRoomEntityclass. Ensure that all references toRoomEntityin the codebase are updated to handle this new property.backend/prisma/seed.ts (1)
- 62-75: The changes in this hunk are consistent with the pull request summary. The
ownerIdfield is added to thecreatecalls forroom1androom2, and theidofuser1anduser2are assigned respectively. This establishes the many-to-one relationship betweenUserandRoomas described in the pull request summary.backend/prisma/schema.prisma (2)
15-19: The
Usermodel now includes aroomfield, establishing a many-to-one relationship with theRoommodel. Ensure that this change is reflected in all parts of the codebase where theUsermodel is used.22-26: The
Roommodel now includes anownerIdfield and a corresponding relation to theUsermodel. This establishes a one-to-many relationship fromUsertoRoom. Ensure that this change is reflected in all parts of the codebase where theRoommodel is used.backend/prisma/migrations/20231111115551_add_oweer_id/migration.sql (4)
1-7: The warnings indicate potential issues with the migration. Ensure that the
Roomtable is empty before running this migration, and that there are no duplicateownerIdvalues.9-9: Adding a non-nullable
ownerIdcolumn to theRoomtable. Ensure that all futureRoomentries will have anownerId.12-12: Creating a unique index on
ownerId. This will help with performance when querying byownerId.15-15: Adding a foreign key constraint on
ownerIdreferencingUser(id). This ensures data integrity betweenRoomandUsertables. TheON DELETE RESTRICTclause prevents a user from being deleted if they own a room, and theON UPDATE CASCADEclause updates theownerIdin theRoomtable if theidin theUsertable is updated.backend/src/room/dto/create-room-request.dto.ts (1)
- 9-13: The
CreateRoomRequestDtoclass is well defined with appropriate decorators for validation and API documentation. Thenameproperty is correctly typed asstring.backend/src/room/room.controller.ts (3)
10-11: The addition of
UseGuardsandReqimports from@nestjs/commonis appropriate for the changes made in thecreatemethod ofRoomController.19-19: The import of
JwtAuthGuardfrom'src/auth/jwt-auth.guard'is necessary for thecreatemethod to useJwtAuthGuard.26-32: The
createmethod inRoomControllerhas been updated to useJwtAuthGuardandApiBearerAuth, and its parameters have been changed fromcreateRoomDtotocreateRoomRequestDtoand@Req() request: Request. This change is consistent with the pull request summary and seems to be a part of the effort to establish a many-to-one relationship betweenUserandRoom.backend/src/room/dto/create-room.dto.ts (1)
- 4-13: The
CreateRoomDtoclass has been updated to remove theidproperty and add anownerIdproperty with aIsNumbervalidator. Ensure that all instances where this DTO is used have been updated to reflect these changes.
a room have many users
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (7)
- backend/prisma/migrations/20231113020147_many_to_many_userroom/migration.sql (1 hunks)
- backend/prisma/migrations/20231113023444_add_role_column_user/migration.sql (1 hunks)
- backend/prisma/schema.prisma (1 hunks)
- backend/prisma/seed.ts (1 hunks)
- backend/src/room/dto/create-room.dto.ts (1 hunks)
- backend/src/room/room.controller.ts (1 hunks)
- backend/src/room/room.service.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- backend/prisma/seed.ts
Additional comments: 9
backend/src/room/dto/create-room.dto.ts (1)
- 1-13: The
CreateRoomDtoclass has been updated to include auserIdproperty. This change is in line with the updates to theRoomandUserentities. Ensure that all instances whereCreateRoomDtois used have been updated to include theuserIdproperty. Also, verify that theuserIdis being validated and sanitized before use.backend/prisma/schema.prisma (3)
15-19: The
Usermodel now includes aroomsfield to represent the many-to-many relationship with theRoommodel. Ensure that all references to theUsermodel in the codebase are updated to handle this new field.22-25: The
Roommodel now includes ausersfield to represent the many-to-many relationship with theUsermodel. Ensure that all references to theRoommodel in the codebase are updated to handle this new field.27-34: The new
useronroommodel establishes a many-to-many relationship betweenUserandRoomwith an additionalrolefield. Ensure that all references to theUserandRoommodels in the codebase are updated to handle this new relationship.backend/prisma/migrations/20231113020147_many_to_many_userroom/migration.sql (4)
1-6: Ensure that the data in the
ownerIdcolumn is not needed anymore or has been migrated to the new structure before applying this migration.7-14: The
ownerIdcolumn is being dropped from theRoomtable. Make sure that this change is reflected in the data model and all the places where this column is being used.17-23: A new table
useronroomis being created. Ensure that this table is properly integrated into the data model and that all necessary relationships are established.26-29: Foreign key constraints are being added to the
useronroomtable. Make sure that these constraints are properly handled in the application logic to avoid database errors.backend/src/room/room.controller.ts (1)
- 26-32: The
createmethod now requires authentication and the request object is used to extract theuserId. Ensure that all calls to this endpoint are updated to include the necessary authentication token in the request header.
backend/prisma/migrations/20231113023444_add_role_column_user/migration.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (5)
- backend/prisma/seed.ts (1 hunks)
- backend/src/room/dto/create-room-request.dto.ts (1 hunks)
- backend/src/room/entities/room.entity.ts (1 hunks)
- backend/src/room/room.controller.ts (1 hunks)
- backend/src/room/room.service.ts (1 hunks)
Additional comments: 8
backend/prisma/seed.ts (1)
- 62-84: The changes look good. The code is connecting users to rooms as expected. However, ensure that the
usersfield and theconnectmethod are correctly implemented in the Prisma client and that theidfield is available in the user objects.backend/src/room/dto/create-room-request.dto.ts (1)
- 1-9: The
CreateRoomRequestDtoclass is well defined with appropriate validation decorators and API property decorator for thenameproperty. Ensure that thenameproperty is being used correctly in the service layer and that the validation decorators are working as expected.backend/src/room/entities/room.entity.ts (2)
5-7: The constructor allows for partial assignment of properties, which can be useful for creating instances with only a subset of properties. However, be aware that this approach can lead to instances with missing required properties. Ensure that all required properties are assigned before using the instance.
14-14: The
ownerIdproperty has been added to theRoomEntityclass. Ensure that this change is reflected in all places whereRoomEntityinstances are created or used.backend/src/room/room.controller.ts (4)
7-12: The import statements are well-organized and only import necessary modules.
26-28: The
RoomControllerclass is properly decorated with@Controllerand@ApiTags, which is good for routing and API documentation.31-43: The
createmethod is now guarded withJwtAuthGuardand requires a bearer token for authentication. This is a good security practice. However, ensure that theJwtAuthGuardis correctly implemented and that therequest['user']['id']is always available after successful authentication.- userId: request['user']['id'], + userId: request.user?.id,
- 45-45: The
findAllmethod is not guarded. If this is intentional and the method should be publicly accessible, then it's fine. Otherwise, consider adding appropriate guards.
There was a problem hiding this comment.
口頭でも言いましたが、一つの機能（PR）の中でmigrationファイルが3つに分かれているのはわかりづらいので、（経過としてはいいですが）、一回migrationファイルを消してからprisma migrate devしなおすとかしてからgit rebaseし直すなどして欲しかったですね！
やり方はわかりますかね？
| return this.roomService.create({ | ||
| ...createRoomRequestDto, | ||
| userId: request['user']['id'], | ||
| }); |
There was a problem hiding this comment.
controllerにロジックは記入するのはいいのかな〜？よくわからぬ
create-room.dtoとcreate-room-request.dtoの二つあることに違和感を持ちました。
serviceファイルにロジックを記入するのがいいかな？こちらを参考に！
https://github.com/usatie/pong/blob/main/backend/src/user/user.service.ts#L17
There was a problem hiding this comment.
こんな感じ？
this.roomService.create(createRoomDto, req.user);
参考になるのかどうかも全然怪しいけど
https://tkssharma.com/nestjs-playing-with-query-param-dto/
Summary by CodeRabbit