Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/backend/room user relation #41
Feat/backend/room user relation #41
Changes from 4 commits
a345e55
06b7669
9b3a7ca
b5f7ac2
d5fcdf6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
口頭でも言いましたが、一つの機能(PR)の中でmigrationファイルが3つに分かれているのはわかりづらいので、(経過としてはいいですが)、一回migrationファイルを消してから
prisma migrate dev
しなおすとかしてからgit rebaseし直すなどして欲しかったですね!やり方はわかりますかね?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
分からない! todo
Check failure on line 3 in backend/src/room/dto/create-room-request.dto.ts
GitHub Actions / Lint Backend
Check failure on line 4 in backend/src/room/dto/create-room-request.dto.ts
GitHub Actions / Lint Backend
Check failure on line 5 in backend/src/room/dto/create-room-request.dto.ts
GitHub Actions / Lint Backend
Check failure on line 5 in backend/src/room/dto/create-room-request.dto.ts
GitHub Actions / Lint Backend
Check failure on line 5 in backend/src/room/dto/create-room-request.dto.ts
GitHub Actions / Lint Backend