Skip to content

Commit

Permalink
add mcap storage plugin (#184)
Browse files Browse the repository at this point in the history
<!-- Thanks for the contribution, this is awesome. -->

# PR Details
This PR adds the foxy mcap storage plugin required to store the recorded
rosbag in mcap format.
## Description
Required for
usdot-fhwa-stol/carma-platform#2285.

<!--- Describe your changes in detail -->

## Related GitHub Issue

<!--- This project only accepts pull requests related to open GitHub
issues or Jira Keys -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please DO NOT name partially fixed issues, instead open an issue
specific to this fix -->
<!--- Please link to the issue here: -->

## Related Jira Key

<!-- e.g. CAR-123 -->
https://usdot-carma.atlassian.net/browse/WFD-474

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Defect fix (non-breaking change that fixes an issue)
- [x] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that cause existing functionality
to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have added any new packages to the sonar-scanner.properties file
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the
[**CONTRIBUTING**](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md)
document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
  • Loading branch information
adev4a authored Jan 22, 2024
2 parents c3f4a7e + a20bb9e commit bc30b32
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Copyright (C) 2018-2021 LEIDOS.
#
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not
# use this file except in compliance with the License. You may obtain a copy of
# the License at
#
#
# http://www.apache.org/licenses/LICENSE-2.0
#
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
Expand Down Expand Up @@ -37,7 +37,7 @@ LABEL org.label-schema.build-date=${BUILD_DATE}
ENV NVIDIA_VISIBLE_DEVICES=${NVIDIA_VISIBLE_DEVICES:-all} \
# Specify which driver libraries/binaries will be mounted inside the container
NVIDIA_DRIVER_CAPABILITIES=${NVIDIA_DRIVER_CAPABILITIES:+$NVIDIA_DRIVER_CAPABILITIES,}graphics

# Avoid interactive prompts during the building of this docker image
ARG DEBIAN_FRONTEND="noninteractive"

Expand Down Expand Up @@ -102,7 +102,7 @@ ARG ROS_DEPS="apt-transport-https \
less \
libboost-python-dev \
libfftw3-dev \
libgeographic-dev \
libgeographic-dev \
libgmock-dev \
libnl-genl-3-dev \
libopenblas-dev \
Expand Down Expand Up @@ -132,6 +132,7 @@ ARG ROS_DEPS="apt-transport-https \
ros-foxy-test-msgs \
ros-foxy-nmea-msgs \
ros-foxy-gps-tools \
ros-foxy-rosbag2-storage-mcap \
ros-noetic-costmap-2d \
ros-noetic-dataspeed-can \
ros-noetic-dbw-mkz \
Expand Down Expand Up @@ -226,10 +227,10 @@ RUN sed -i 's|http://archive.ubuntu.com|http://us.archive.ubuntu.com|g' /etc/apt
# Unzip scanner
unzip $SONAR_DIR/sonar-scanner.zip -d "$SONAR_DIR"/ && \
unzip $SONAR_DIR/build-wrapper.zip -d "$SONAR_DIR"/ && \
# Remove zip files
# Remove zip files
rm $SONAR_DIR/sonar-scanner.zip && \
rm $SONAR_DIR/build-wrapper.zip && \
# Rename files
# Rename files
mv "$SONAR_DIR"/sonar-scanner-* "$SONAR_DIR"/sonar-scanner/ && \
mv "$SONAR_DIR"/build-wrapper-* "$SONAR_DIR"/build-wrapper/ && \
# FIXME: The following symlink will no longer be required once images
Expand Down

0 comments on commit bc30b32

Please sign in to comment.