[DO NOT MERGE] Docker config for carma-base to be built in ARM with ROS2 Humble for C1T #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need to implement a way to chose the correct carma-base image based on what system architecture is in use before this can be merged to develop |
adamlm
suggested changes
Mar 7, 2024
Dockerfile
Outdated
Comment on lines
146
to
148
| # NOTICE: needs to be chmod +x | ||
| COPY install_pkgs.sh install_pkgs.sh | ||
| RUN ./install_pkgs.sh |
There was a problem hiding this comment.
We can explicitly chmod instead of relying on the file to already have the executable bit set. See here.
There was a problem hiding this comment.
requires docker buildkit which is annoying, should we assume people have that?
adamlm
suggested changes
Mar 11, 2024
adamlm
approved these changes
Mar 11, 2024
|
@willjohnsonk Do we need this now? Could we close it if not needed anymore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Several CARMA Docker components rely on carma-base as a base image to use when building. Since carma-base exclusively targets x86 systems with ROS1 noetic and ROS2 foxy it needs to be updated to support the Nvidia Jetson ARM computer used by C1T.
Related GitHub Issue
Related Jira Key
CF-790
Motivation and Context
Provides a Docker build process for using carma-base on ARM devices with ROS2 Humble
How Has This Been Tested?
Types of changes
Checklist: