Rename trailing suffix to use ROS names #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adev4a
reviewed
Oct 14, 2024
adev4a
approved these changes
Oct 15, 2024
MishkaMN
added a commit
that referenced
this pull request
Oct 15, 2024
* add scheduled * rename folders * Fix naming * noetic-foxy * Specify the noetic comment
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Renamed the folders to use ROS based names such as noetic-foxy or humble to create Docker images.
Currently named the focal into noetic-foxy to indicate both exist.
In the future, in branch
humble-develop, onlynoeticfolder will exist.I also rearranged humble Dockerfile to actually use caching (the metadata changes everytime when we use the build-image.sh script, so the image starts from the beginning since the metadata is declared in the beginning stages).
Related GitHub Issue
NA
Related Jira Key
ARC-155 and ARC-154
Motivation and Context
Upgrade to Humble
How Has This Been Tested?
Ci builds fine without issues
Types of changes
Checklist: