-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual compute support for Docker-Compose, migration from volumes-from to named volumes #274
Draft
willjohnsonk
wants to merge
10
commits into
develop
Choose a base branch
from
test/dual-compute
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luding shift from volumes-from to an external, named volume
Much of this added functionality depends on changes in the Docker CLI process. Those will be reflected in a new CARMA Platform branch that updates the carma script. |
JonSmet
reviewed
Nov 20, 2023
JonSmet
requested changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Docker Swarm was decided upon to allow for the distribution of CARMA Docker services across two PCs. The primary docker-compose.yml file has been split into two files: docker-compose-manager.yml and docker-compose-worker.yml. These compose files as well as docker-compose-background-manager.yml have additionally been updated to use external Docker volumes instead of the previous volumes-from method.
Related Issue
CF-662
Motivation and Context
Allows for the use of two separate PCs, Docker Swarm, and updates Docker Compose usage to current standards.
How Has This Been Tested?
Launched updated docker-compose-background.yml through terminal and successfully added service to Swarm stack
Types of changes
Checklist:
CARMA Contributing Guide