Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual compute support for Docker-Compose, migration from volumes-from to named volumes #274

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

willjohnsonk
Copy link

@willjohnsonk willjohnsonk commented Oct 18, 2023

PR Details

Description

Docker Swarm was decided upon to allow for the distribution of CARMA Docker services across two PCs. The primary docker-compose.yml file has been split into two files: docker-compose-manager.yml and docker-compose-worker.yml. These compose files as well as docker-compose-background-manager.yml have additionally been updated to use external Docker volumes instead of the previous volumes-from method.

Related Issue

CF-662

Motivation and Context

Allows for the use of two separate PCs, Docker Swarm, and updates Docker Compose usage to current standards.

How Has This Been Tested?

Launched updated docker-compose-background.yml through terminal and successfully added service to Swarm stack

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@willjohnsonk
Copy link
Author

Much of this added functionality depends on changes in the Docker CLI process. Those will be reflected in a new CARMA Platform branch that updates the carma script.

development/docker-compose-pc2.yml Outdated Show resolved Hide resolved
development/docker-compose-background-pc1.yml Outdated Show resolved Hide resolved
development/docker-compose-pc1.yml Outdated Show resolved Hide resolved
development/docker-compose-background.yml Outdated Show resolved Hide resolved
development/docker-compose.yml Outdated Show resolved Hide resolved
development/carma.env Outdated Show resolved Hide resolved
development/carma.env Outdated Show resolved Hide resolved
development/carma_docker.launch.py Outdated Show resolved Hide resolved
development/carma_docker.launch.py Outdated Show resolved Hide resolved
development/docker-compose-manager.yml Show resolved Hide resolved
development/docker-compose-manager.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants