Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voices/vug pilot2 #341

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Voices/vug pilot2 #341

wants to merge 11 commits into from

Conversation

adev4a
Copy link
Contributor

@adev4a adev4a commented Apr 19, 2024

PR Details

Adds config params required for voices.

Description

The VOICES project uses the CARMA Platform with the CARMA CARLA integration, but does not use the rest of CDA Sim. A new config folder was added with minor changes and tuning specifically for this use and the Mcity CARLA map.

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adev4a adev4a requested a review from MishkaMN April 19, 2024 14:32
Copy link
Contributor

@MishkaMN MishkaMN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove all the files that are not needed for voices.
For example, I think the whole cdasim_config folder can be moved right?
And it'd be great if we could give some high level documentation about what the scenario is about and replace the ones in docs
it'd be good if we could include osm map, MAP uper, or evc controller configurations so we have a version control. *As long as it is allowed for us to publish them

# Defines the ros parameters which define the characteristics of this host vehicle configuration
# The value type field is used to indicate how the field should be set.
# Should it be treated as a measured value (Measured) or a desired behavior constraint (Desired)
use_sim_time: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wall time argument is missing. Could you also add the parameter to vru yaml file and set it false since it doesnt use wall time in its spat?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adev4a
please remember to add to ail_vru_uc1_scenario folder and set it false otherwise cdasim would break down. I would even add to xil_cloud and telematics ones as well.

@adev4a
Copy link
Contributor Author

adev4a commented Apr 19, 2024

Lets remove all the files that are not needed for voices. For example, I think the whole cdasim_config folder can be moved right? And it'd be great if we could give some high level documentation about what the scenario is about and replace the ones in docs it'd be good if we could include osm map, MAP uper, or evc controller configurations so we have a version control. *As long as it is allowed for us to publish them

@ajloughr-leidos can you look into this?

# Defines the ros parameters which define the characteristics of this host vehicle configuration
# The value type field is used to indicate how the field should be set.
# Should it be treated as a measured value (Measured) or a desired behavior constraint (Desired)
use_sim_time: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adev4a
please remember to add to ail_vru_uc1_scenario folder and set it false otherwise cdasim would break down. I would even add to xil_cloud and telematics ones as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants