Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #330 to maintain launch of ROS 1 points_concat_filter node in freightliner CARMA Configs #374

Draft
wants to merge 1 commit into
base: release/miura
Choose a base branch
from

Conversation

JonSmet
Copy link
Contributor

@JonSmet JonSmet commented Aug 7, 2024

PR Details

Description

This PR reverts PR #330 from the release/miura branch, since this update depends on a related PR in the Autoware.Auto fork (relevant PR here: Click Here) used in CARMA Platform. Since CARMA Platform is not being released in step with the Miura release, this changeset should not be released in carma-config for the Miura release.

Related Issue

TODO add Jira Ticket

Motivation and Context

Without this PR, the freightliner CARMA Configs will not work for the Miura release. Even if DockerHub images are not released, a user would still run into issues if trying to build/use these configs from source.

How Has This Been Tested?

Not tested explicitly, only visually reviewed since this is a small changeset.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JonSmet JonSmet marked this pull request as draft August 7, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant