#205 Address clang compiler errors

The CarmaLifecycleNode has some compilation errors that were not
caught by GCC due to a bug in the compiler. Clang-Tidy uses the Clang
compiler, which did not have that bug. Newer versions of GCC are
patched.

carma_ros2_utils/include/carma_ros2_utils/internal/carma_lifecycle_node.tpp

@@ -22,13 +22,10 @@ namespace carma_ros2_utils
   template <
       typename MessageT,
       typename CallbackT,
-      typename AllocatorT = std::allocator<void>,
-      typename CallbackMessageT =
-          typename rclcpp::subscription_traits::has_message_type<CallbackT>::type,
-      typename SubscriptionT = rclcpp::Subscription<MessageT, AllocatorT>,
-      typename MessageMemoryStrategyT = rclcpp::message_memory_strategy::MessageMemoryStrategy<
-          CallbackMessageT,
-          AllocatorT>>
+      typename AllocatorT,
+      typename CallbackMessageT,
+      typename SubscriptionT,
+      typename MessageMemoryStrategyT>
   std::shared_ptr<SubscriptionT>
   CarmaLifecycleNode::create_subscription(
       const std::string &topic_name,
@@ -41,7 +38,7 @@ namespace carma_ros2_utils
     return rclcpp_lifecycle::LifecycleNode::create_subscription<MessageT>(
         topic_name, qos,
         // The move capture "callback = std::move(callback)" is specifically needed
-        // here because of the unique_ptr<> in the callback arguments 
+        // here because of the unique_ptr<> in the callback arguments
         // when the callback is provided with std::bind
         // the returned functor degrades to be move-constructable not copy-constructable
         // https://www.cplusplus.com/reference/functional/bind/
@@ -54,7 +51,7 @@ namespace carma_ros2_utils
           }
           catch(const std::exception &e)
           {
-            handle_primary_state_exception(e); 
+            handle_primary_state_exception(e);
 
           } catch (...) {
             handle_primary_state_exception();
@@ -63,7 +60,7 @@ namespace carma_ros2_utils
         options, msg_mem_strat);
   }
 
-  template <typename MessageT, typename AllocatorT = std::allocator<void>>
+  template <typename MessageT, typename AllocatorT>
   std::shared_ptr<rclcpp_lifecycle::LifecyclePublisher<MessageT, AllocatorT>>
   CarmaLifecycleNode::create_publisher(
       const std::string &topic_name,
@@ -75,7 +72,7 @@ namespace carma_ros2_utils
     return pub;
   }
 
-  template <typename DurationRepT = int64_t, typename DurationT = std::milli, typename CallbackT>
+  template <typename DurationRepT, typename DurationT, typename CallbackT>
   std::shared_ptr<rclcpp::TimerBase>
   CarmaLifecycleNode::create_wall_timer(
       std::chrono::duration<DurationRepT, DurationT> period,
@@ -92,7 +89,7 @@ namespace carma_ros2_utils
       }
       catch(const std::exception &e)
       {
-        handle_primary_state_exception(e); 
+        handle_primary_state_exception(e);
 
       } catch (...) {
         handle_primary_state_exception();
@@ -154,8 +151,8 @@ namespace carma_ros2_utils
           }
           catch(const std::exception &e)
           {
-            handle_primary_state_exception(e); 
-            
+            handle_primary_state_exception(e);
+
           } catch (...) {
             handle_primary_state_exception();
           }
@@ -166,15 +163,15 @@ namespace carma_ros2_utils
   template <class ServiceT>
   typename rclcpp::Client<ServiceT>::SharedPtr
   CarmaLifecycleNode::create_client (
-    const std::string service_name, 
+    const std::string service_name,
     const rmw_qos_profile_t & qos_profile,
     rclcpp::CallbackGroup::SharedPtr group
   )
   {
     // nullptr is the default argument for group
     // when nullptr is provided use the class level service group
     // this is needed instead of a default argument because you cannot change default arguments in overrides
-    if (group == nullptr) { 
+    if (group == nullptr) {
       group = this->service_callback_group_;
     }
 
@@ -188,9 +185,9 @@ namespace carma_ros2_utils
    * \brief Internal helper method to compare a ParameterType with a template argument
    * \tparam T The compiled type to compare
    * \param type The ROS ParameterType to compare
-   * 
+   *
    * \return true if the ParameterType matches the template argument. False otherwise.
-   */ 
+   */
   template<typename T>
   bool same_param_type(const rclcpp::ParameterType& type)
   {
@@ -219,26 +216,26 @@ namespace carma_ros2_utils
 
       case rclcpp::ParameterType::PARAMETER_STRING_ARRAY:
         return std::is_same_v<T, std::vector<std::string>>;
-    
+
       default:
         return false;
     }
   }
 
   template<typename T>
   boost::optional<std::string> CarmaLifecycleNode::update_params(const std::unordered_map<std::string, std::reference_wrapper<T>>& update_targets,
-                   const std::vector< rclcpp::Parameter > & new_params) 
+                   const std::vector< rclcpp::Parameter > & new_params)
   {
     std::unordered_map<std::string, std::function<T(T)>> func_map;
     func_map.reserve(update_targets.size());
 
     // Create setter methods for all reference parameters
     for (auto& pair : update_targets) {
-      func_map[pair.first] = [&pair](T t) { 
-        
+      func_map[pair.first] = [&pair](T t) {
+
         T temp = pair.second;
         pair.second.get() = t; // Assign to the reference
-        return temp; 
+        return temp;
 
       };
     }
@@ -261,7 +258,7 @@ namespace carma_ros2_utils
 
         std::string error = "Cannot update parameter " + param.get_name() + " it has mismatched type " + typeid(T).name() + " and " + param.get_type_name();
         RCLCPP_ERROR_STREAM(get_logger(), error);
-      
+
         return error;
       }