fix: duplicated bindings in the activity API

[ShookLyngs]

Previous PR

• feat: add rgbpp address activity api  #182

Changes

• Add RgbppCollector.isIsomorphicTx() method to help validate isomorphic transactions in depth and fix the duplicated binding recognization issue in RgbppCollector.queryRgbppLockTxByBtcTx
  • Previously mentioned in Review fn queryRgbppLockTxByBtcTx and queryBtcTimeLockTxByBtcTxId #193
• Fix the validate logic of RgbppCollector.queryBtcTimeLockTxByBtcTxId()
  • Previously mentioned in Review fn queryRgbppLockTxByBtcTx and queryBtcTimeLockTxByBtcTxId #193
• Rename ckbRawTx to ckbVirtualTx in the IsomorphicTransaction type
  • Originally commented at feat: add rgbpp address activity api  #182 (comment)

TODO

• Test: query L1-L1 transactions
  • Query via route: /rgbpp/v1/address/tb1qrkh7g0gkllttvsu9kzm7f5c25agnj8ype88xsg/activity
  • View transaction on RGB++ Explorer
• Test: query L1-L2 transactions
  • Query via route: /rgbpp/v1/address/tb1qrkh7g0gkllttvsu9kzm7f5c25agnj8ype88xsg/activity
  • View transaction on RGB++ Explorer
• Test: query L1-L1/L2-l1 multi-bound UTXO
  1. L1-L1 that generates a new UTXO a986...245c:1
     • Query via route: /rgbpp/v1/address/tb1ql4rmhtkzdf043cq4a876y2fsq6wqqh02njwsf7/activity
     • View transaction on RGB++ Explorer
  2. L2-L1 that leaps asset to the same UTXO a986...245c:1
     • View transaction on RGB++ Explorer

Issues

1. We can only reverse search L1-L1 and L1-L2 transactions with BTC TxIds, as only these types of transactions will ensure at least one rgbpp-lock cell is included in the inputs. For other types of transactions, we will have trouble identifying duplicated binding assets in them.
2. The RgbppCollector.queryBtcTimeLockTxByBtcTxId() method has an issue where the CkbIndexer.getTransactions() method requires manual pagination. This part is currently missing in the codebase, so the method only searches the first 100 records in the blockchain, causing inaccurate matching results of the btc-time-lock transactions.
   related issue: Optimize the search process for BTC_TIME_LOCK ckb transactions #45

[vercel]

@ShookLyngs is attempting to deploy a commit to the Cell Studio Team on Vercel.

To accomplish this, @ShookLyngs needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
btc-assets-api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 21, 2024 6:53pm

[ShookLyngs]

@ahonn IS_MAINNET and TESTNET_TYPE are created in the constants.ts file to simplify things. If you are okay with the constants, I can create another PR to refactor the codebase to use these constants instead of using env.NETWORK everywhere:

-getXScript(env.NETWORK === NetworkType.mainnet.toString())
+getXScript(IS_MAINNET)

[ahonn]

@ahonn IS_MAINNET and TESTNET_TYPE are created in the constants.ts file to simplify things. If you are okay with the constants, I can create another PR to refactor the codebase to use these constants instead of using env.NETWORK everywhere:

-getXScript(env.NETWORK === NetworkType.mainnet.toString())

+getXScript(IS_MAINNET)

LGTM

[Flouse]

The preview deployment is ready. 🟢

Open Preview

Hi, @Dawn-githup
https://194.assets-api-342ddd42.nip.io/docs is the PR preview link for testing.

Related test

• feat: add rgbpp address activity api  #182 (comment)

[ahonn]

LGTM

[Dawn-githup]

curl 'https://btc-assets-api-git-fix-182-duplicated-bindings-cell-studio.vercel.app/rgbpp/v1/address/tb1q4vsuv95gdum3cdrswujv9qzqf72ehqxh7vhhak/activity?rgbpp_only=false' \

It is recommended to cache the data. It takes a long time to check the data now.

[Dawn-githup]

The preview deployment is ready. 🟢
Open Preview

Hi, @Dawn-githup https://194.assets-api-342ddd42.nip.io/docs is the PR preview link for testing.

Related test

• feat: add rgbpp address activity api  #182 (comment)

updated

#182 (comment)