Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

63/feature/metapackages #67

Merged
merged 4 commits into from
Nov 10, 2023
Merged

63/feature/metapackages #67

merged 4 commits into from
Nov 10, 2023

Conversation

AaronYoung5
Copy link
Collaborator

#63

@AaronYoung5 AaronYoung5 changed the base branch from master to 59/feature/vehicle-specific-services November 5, 2023 20:09
@AaronYoung5
Copy link
Collaborator Author

AaronYoung5 commented Nov 5, 2023 •
edited
Loading

Don't review, file diffs are weird.

@AaronYoung5 AaronYoung5 changed the base branch from 59/feature/vehicle-specific-services to master November 5, 2023 20:19
@AaronYoung5 AaronYoung5 force-pushed the 63/feature/metapackages branch from 4702da8 to f2f33a2 Compare November 5, 2023 20:24
@AaronYoung5
Copy link
Collaborator Author

@StefanCaldararu no rush on review, lot here. Read docs for background on metapackages and how to use them. This is probably a longer discussion.

@AaronYoung5 AaronYoung5 self-assigned this Nov 5, 2023
@AaronYoung5 AaronYoung5 mentioned this pull request Nov 5, 2023
Closed
StefanCaldararu
StefanCaldararu reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@StefanCaldararu StefanCaldararu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks FIRE 🔥 maybe good to get other people to at least look at this as well so they are somewhat familiar with it before you merge. Tested this out and it worked for me; is there any other dev that needs to be done here?

docs/README.md Show resolved Hide resolved
docs/design/ros_workspace.md Show resolved Hide resolved
atk.yml Outdated Show resolved Hide resolved
workspace/src/localization/localization_py/localization_py/state_estimation.py Outdated Show resolved Hide resolved
@AaronYoung5 AaronYoung5 force-pushed the 63/feature/metapackages branch from 024873c to ef32adc Compare November 6, 2023 14:07
StefanCaldararu
StefanCaldararu approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@StefanCaldararu StefanCaldararu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... also saw you pinged people in #60 so fine to merge imo if this is ready.

@AaronYoung5 AaronYoung5 merged commit b6b6cc0 into master Nov 10, 2023
1 check passed
@AaronYoung5 AaronYoung5 deleted the 63/feature/metapackages branch November 10, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanCaldararu StefanCaldararu StefanCaldararu approved these changes

Assignees

@AaronYoung5 AaronYoung5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronYoung5 @StefanCaldararu