feat(warning): Add generic gas fee warning component #6385

finnian0826 · 2024-12-18T18:22:12Z

Description

Generic gas warning create in GasFeeWarning.tsx. Used in EarnEnterAmount. For cases 2-5 rounded n is omitted, since it is difficult to find for cases 2-4, and in case 5 there is no cta so no immediate action to be taken (slack thread discussing here).

Analytics added for when the error shows, analytics for cta press are to be included in the onPressCta prop.

Test plan

EarnEnterAmount unit test updated
GasFeeWarning unit tests created

NEW Manual Testing

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-08.at.13.59.31.mp4

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-08.at.13.57.32.mp4

OLD Manual Testing:
Not enough gas currency:
| | |

Transacting with max amount:
| | |

Dapp:

Tapping CTA:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-30.at.14.49.28.mp4

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-31.at.12.07.10.mp4

Related issues

Fixes ACT-1482

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

codecov · 2024-12-23T17:52:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (e72427d) to head (ec8c5d5).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6385      +/-   ##
==========================================
+ Coverage   89.09%   89.10%   +0.01%     
==========================================
  Files         736      737       +1     
  Lines       31838    31884      +46     
  Branches     6040     6052      +12     
==========================================
+ Hits        28366    28411      +45     
- Misses       3276     3425     +149     
+ Partials      196       48     -148

Files with missing lines	Coverage Δ
src/analytics/Events.tsx	`100.00% <100.00%> (ø)`
src/analytics/Properties.tsx	`100.00% <ø> (ø)`
src/components/GasFeeWarning.tsx	`100.00% <100.00%> (ø)`
src/components/InLineNotification.tsx	`100.00% <100.00%> (ø)`
src/earn/EarnEnterAmount.tsx	`93.75% <100.00%> (-0.18%)`	⬇️
src/viem/prepareTransactions.ts	`99.09% <ø> (ø)`

... and 67 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72427d...ec8c5d5. Read the comment docs.

finnian0826 · 2024-12-31T18:59:17Z

src/components/GasFeeWarning.tsx

+  const feeCurrencySymbol =
+    prepareTransactionsResult.type === 'not-enough-balance-for-gas'
+      ? prepareTransactionsResult.feeCurrencies[0].symbol


In the designs, it seems like it leans towards hardcoding this to be CELO or ETH (this is cases 2-4), however in all of the use cases currently it is done like this (using prepareTransactionsResult.feeCurrencies[0]). I think it is easier to keep it this way for two reasons:

ETH tokenId is not available in NetworkConfig, and would be needed for CTA (in order to prefill in CICO flow), so would need to be added for all networks, increasing amount of hardcoded things

The CTA is implemented in the component that uses this warning, so the implementer would have to get the hardcoded tokenId based on the network of the prepared transaction, rather than just looking at the first feeCurrencies.

I can add in the ETH tokenId's if we want but wanted to check first about doing it this way instead.

locales/base/translation.json

src/components/GasFeeWarning.test.tsx

src/analytics/Properties.tsx

src/components/GasFeeWarning.tsx

emerge-tools · 2025-01-02T16:56:47Z

📸 Snapshot Test

No snapshots generated

Name	Added	Removed	Modified	Renamed	Unchanged	Errored	Approval
Celo (test) org.celo.mobile.test	0	0	0	0	0	0	N/A

🛸 Powered by Emerge Tools

satish-ravi · 2025-01-02T16:53:29Z

src/analytics/docs.ts

@@ -67,6 +67,7 @@ export const eventDocs: Record<AnalyticsEventType, string> = {
  [AppEvents.in_app_review_impression]: `User sees an in-app review request`,
  [AppEvents.in_app_review_error]: `Error while attempting to display in-app review`,
  [AppEvents.handle_deeplink]: `When a deeplink that leads into the app is detected and handled`,
+  [AppEvents.show_gas_fee_warning]: `When the gas fee warning is shown to the user`,


Suggested change

[AppEvents.show_gas_fee_warning]: `When the gas fee warning is shown to the user`,

[AppEvents.gas_fee_warning_impression]: `When the gas fee warning is shown to the user`,

?

satish-ravi · 2025-01-02T16:56:36Z

src/components/GasFeeWarning.tsx

+      ? prepareTransactionsResult.feeCurrencies[0]
+      : prepareTransactionsResult.feeCurrency
+
+  const flowToNotEnoughGasDescriptionString = {


you can consider using context instead of doing this mapping yourself. E.g., the translation strings could be made something like gasFeeWarning.description.notEnoughGas_<GasFeeWarningFlow>, and then you can just do t('gasFeeWarning.description.notEnoughGas', { context: <GasFeeWarningFlow>, tokenSymbol })
There are other places in the app where we do this if you want a complete example

satish-ravi · 2025-01-02T17:04:16Z

src/components/GasFeeWarning.test.tsx

+    expect(queryByTestId('test/GasFeeWarning')).toBeFalsy()
+  })
+  it.each`
+    scenario                                      | flow                          | prepareTransactionsResult                  | feeCurrencyTokenId   | title                                            | description                                                                    | ctaLabel


I guess it doesn't hurt but whats the value of testing all the different variants with 2 different symbols? We don't seem to be doing anything custom depending on symbols

I was trying to have test coverage for all the cases outlined by product in the figma doc, and those cases include Celo and non-Celo chains so I had one of each

ok, I guess figma had those differences because celo is the only one with multiple gas tokens, we don't really handle that in this component, so it seems superfluous to test the variations.

satish-ravi · 2025-01-02T19:24:44Z

src/earn/EarnEnterAmount.tsx

+          onPressCta={() => {
+            AppAnalytics.track(EarnEvents.earn_deposit_add_gas_press, {
+              gasTokenId: feeCurrencies[0].tokenId,
+              depositTokenId: pool.dataProps.depositTokenId,
+              networkId: pool.networkId,
+              providerId: pool.appId,
+              poolId: pool.positionId,
+            })
+            if (prepareTransactionsResult && prepareTransactionsResult.type !== 'possible') {
+              prepareTransactionsResult.type === 'not-enough-balance-for-gas'
+                ? navigate(Screens.FiatExchangeAmount, {
+                    tokenId: prepareTransactionsResult.feeCurrencies[0].tokenId,
+                    flow: CICOFlow.CashIn,
+                    tokenSymbol: prepareTransactionsResult.feeCurrencies[0].symbol,
+                  })
+                : handleAmountInputChange(prepareTransactionsResult.decreasedSpendAmount.toString())
+            }
+          }}


Is this something that can be done in the warning component? Seems inconsistent to have the component define the CTA label, but the action is defined by the consumer. I assume this is going to be the same for all usages?

In the AC of the ticket it says that the component should have an optional action prop for handling the CTA, so I thought that meant to pass in an onPress function. But I agree I think it makes more sense for the CTA to exist within the component because "Buy CELO" should always do the same thing, regardless of flow. @MuckT was there a reason to pass in the CTA?

@satish-ravi @MuckT if we had the CTA onPress function inside the warning component, then we would also have to use a generic analytics event, or add another prop for which analytics event should be used for the CTA press. Not sure which of those we would want to do?

satish-ravi · 2025-01-02T19:25:04Z

src/components/GasFeeWarning.tsx

+import { Spacing } from 'src/styles/styles'
+import { PreparedTransactionsResult } from 'src/viem/prepareTransactions'
+
+export enum GasFeeWarningFlow {


did you consider string literals over enum for this?

no but I can change it to that, in Valora should we prefer string literals over enums? Or what is the convention?

Don't think we have a defined convention, but we did talk about this in an eng sync and I think we've been favoring literals over enums recently

Additional feedback / changes

jophish · 2025-01-06T17:35:34Z

src/components/GasFeeWarning.tsx

+  prepareTransactionsResult,
+  flow,
+  changeInputValueFn,
+  testIdPrefix,


Is this required in order to disambiguate warnings? We should never have more than one of these warnings at once, no? Or is this just to add additional context to the test ID?

This was just to add additional context to the test ID to make it clearer in tests, but you're right there should never be more than one at once so it is not needed. I can remove if that would be cleaner.

removed in d6b4c16

jophish · 2025-01-06T17:50:09Z

src/components/GasFeeWarning.tsx

+    return false
+  }
+
+  const feeCurrency =


Trying to determine which of these conditions in the nested ternarys below correspond to which cases from the Figma was a bit cumbersome, though not sure if there's a better way (e.g., switching over error type so we don't have to repeat the same flow/error checks multiple times. you could also define the cta action this way as well so as not to have to repeat the error check again in onPressCta)

Yeah I could make a switch case for each of the error types and define all of the relevant things within each case. That would make it easier to add new error types if they come up (as you mentioned in your other comment), but not sure what the default/fallback should be?

Typescript supports type safety to ensure that all possible cases are handled, as here, so you could use this as the contents of your default case. Conveniently, this will give us compile errors if we ever add a new error type without handling it here.

jophish · 2025-01-06T17:53:46Z

src/components/GasFeeWarning.tsx

+  const feeCurrency =
+    prepareTransactionsResult.type === 'not-enough-balance-for-gas'
+      ? prepareTransactionsResult.feeCurrencies[0]
+      : prepareTransactionsResult.feeCurrency


i wonder if we'll ever add another error type/string to the transaction result object -- as it is now, we catch the need-decrease-spend-amount-for-gas case implicitly, but if we ever add anything else, this will break silently. it's probably not a big deal, but wonder if we should be more explicit about that check?

jophish · 2025-01-06T17:56:08Z

src/components/GasFeeWarning.tsx

+            tokenSymbol: feeCurrency.symbol,
+          })
+        : t('gasFeeWarning.descriptionMaxAmount', {
+            context: flow,


is the context set up correctly here? AFAIK the way that context is used is by defining translation strings like someString_CONTEXT1, someString_CONTEXT2 in the translation file, but currently you have the "context" strings as nested objects, which differs from the way other context strings are used within this PR.

Ahh yeah I didn't change that one over, I will fix that now

satish-ravi · 2025-01-06T22:19:46Z

src/analytics/Properties.tsx

+  [AppEvents.gas_fee_warning_impression]: {
+    flow: GasFeeWarningFlow
+    errorType: 'need-decrease-spend-amount-for-gas' | 'not-enough-balance-for-gas'
+    tokenId: string
+  }
+  [AppEvents.gas_fee_warning_cta_press]: {
+    flow: GasFeeWarningFlow
+    errorType: 'need-decrease-spend-amount-for-gas' | 'not-enough-balance-for-gas'
+    tokenId: string
+  }


can we include networkId

added for both events in c34fbe6

satish-ravi · 2025-01-07T00:47:58Z

locales/base/translation.json

+    "descriptionNotEnoughGas_Send": "Adjust the amount you're sending or add {{tokenSymbol}} to continue",
+    "descriptionNotEnoughGas_Swap": "Adjust the amount you're swapping or add {{tokenSymbol}} to continue",
+    "descriptionNotEnoughGas_Deposit": "Adjust the amount you're depositing or add {{tokenSymbol}} to continue",
+    "descriptionNotEnoughGas_Withdraw": "Adjust the amount you're withdrawing or add {{tokenSymbol}} to continue",


I just talked to product earlier today about this, I don't think adjusting the amount will make a difference as this is triggered when the user doesn't have the minimum amount for gas. Not sure if the copy is finalized here, so we could do this in a follow up PR too.

Is that linked design saying that there will not be a description, or has the copy just not been added yet?

not sure if its final. Would be good to check with product

checked with product and confirmed it should be empty, so removed and updated in 81a166d

satish-ravi · 2025-01-07T00:49:12Z

src/components/GasFeeWarning.tsx

+}: {
+  prepareTransactionsResult?: PreparedTransactionsResult
+  flow: GasFeeWarningFlow
+  changeInputValueFn?: (amount: string) => void


onPressSmallerAmount?

updated in c34fbe6

satish-ravi · 2025-01-07T00:52:18Z

src/components/GasFeeWarning.tsx

+  const title =
+    flow === 'Dapp'
+      ? t('gasFeeWarning.titleDapp')
+      : t('gasFeeWarning.title', { tokenSymbol: feeCurrency.symbol })
+  const description =
+    flow === 'Dapp'
+      ? t('gasFeeWarning.descriptionDapp', { tokenSymbol: feeCurrency.symbol })
+      : prepareTransactionsResult.type === 'not-enough-balance-for-gas'


have you considered using context for Dapp too and avoid this nested ternary? Don't feel strongly but you could also do something like the below, which might be more readable

const { title, description, ctaLabel } = useMemo(() => { if (dapp) { return { title, description, ctaLabel } } else if (notEnoughBalanceForGas) { return { title, description, ctaLabel } } else { return { title, description, ctaLabel } } }, [deps])

updated in 0459e45, used context for title, but used the if/else for description and ctaLabel since those already had context for some of the string so didn't want to try to mess with having double context

the useMemo had to be moved higher in the file and so has some weird checks, added a comment below about it

satish-ravi · 2025-01-07T00:58:38Z

src/components/GasFeeWarning.tsx

+    prepareTransactionsResult.type === 'not-enough-balance-for-gas'
+      ? navigate(Screens.FiatExchangeAmount, {
+          tokenId: feeCurrency.tokenId,
+          flow: CICOFlow.CashIn,
+          tokenSymbol: feeCurrency.symbol,
+        })
+      : changeInputValueFn
+        ? changeInputValueFn(prepareTransactionsResult.decreasedSpendAmount.toString())
+        : null


use if over ternary here

updated in c34fbe6

finnian0826 · 2025-01-07T17:36:09Z

src/components/GasFeeWarning.tsx

+    }
+  }, [prepareTransactionsResult])
+
+  const { title, description, ctaLabel } = useMemo(() => {


The useMemo is kind of weird because it cannot be conditional (can't be after the return false), so has to do extra checks. Not sure if there is a better way?

you can return an empty object instead of explicitly null. And you can check the condition below (where the component returns false) to just check if title is undefined, so that way you don't need to repeat the preparedTransaction check again.

updated in 81a166d

satish-ravi · 2025-01-08T08:09:25Z

src/components/GasFeeWarning.tsx

+    } else {
+      onPressSmallerAmount


this can be an else if instead of an else then ternary. Or you can also use optional chaining operator e.g., onPressSmallerAmount?.(...)

updated in 81a166d

satish-ravi · 2025-01-08T08:13:55Z

src/components/GasFeeWarning.tsx

+    }
+  }, [prepareTransactionsResult])
+
+  const { title, description, ctaLabel } = useMemo(() => {


you can return an empty object instead of explicitly null. And you can check the condition below (where the component returns false) to just check if title is undefined, so that way you don't need to repeat the preparedTransaction check again.

satish-ravi · 2025-01-08T17:24:32Z

locales/base/translation.json

+    "descriptionNotEnoughGas_Send": "Adjust the amount you're sending or add {{tokenSymbol}} to continue",
+    "descriptionNotEnoughGas_Swap": "Adjust the amount you're swapping or add {{tokenSymbol}} to continue",
+    "descriptionNotEnoughGas_Deposit": "Adjust the amount you're depositing or add {{tokenSymbol}} to continue",
+    "descriptionNotEnoughGas_Withdraw": "Adjust the amount you're withdrawing or add {{tokenSymbol}} to continue",


not sure if its final. Would be good to check with product

satish-ravi · 2025-01-08T17:26:11Z

src/earn/EarnEnterAmount.test.tsx

@@ -928,7 +928,7 @@ describe('EarnEnterAmount', () => {
    })
  })

-  it('should track analytics and navigate correctly when tapping cta to add gas', async () => {
+  it('should show gas warning error when prepareTransactionsResult is type not-enough-balance-for-gas, and tapping cta behaves as expected', async () => {


should we also add a test for the need-decrease-spend-amount-for-gas? since the cta action for that is set by EarnEnterAmount

new unit test added in 81a166d

finnian0826 · 2025-01-08T21:18:49Z

src/components/InLineNotification.tsx

@@ -82,7 +82,7 @@ export function InLineNotification({
        )}
        <View style={styles.contentContainer}>
          {!!title && <Text style={styles.titleText}>{title}</Text>}
-          <Text style={[styles.bodyText]}>{description}</Text>
+          {!!description && <Text style={[styles.bodyText]}>{description}</Text>}


This was needed for spacing to be correct in the new case where there is no description. But is it okay for the view to possibly be empty? Or do I need to do something like (!title && !description) || !!description?

not sure I understand your proposal. Would there even be a usage of this component with both title and description not set?

satish-ravi

A w/ nits

satish-ravi · 2025-01-08T23:23:38Z

src/analytics/Events.tsx

+  gas_fee_warning_impression = 'gas_fee_warning_impression',
+  gas_fee_warning_cta_press = 'gas_fee_warning_cta_press',


nit: move this to FeeEvents? I think the two events currently there may not even be used anymore though, so could just replace these with those.

satish-ravi · 2025-01-08T23:25:18Z

src/components/GasFeeWarning.tsx

+      return {}
+    }
+    const title = t('gasFeeWarning.title', {
+      context: flow === 'Dapp' ? 'Dapp' : undefined,


Suggested change

context: flow === 'Dapp' ? 'Dapp' : undefined,

context: flow

I think this should work the same, if a string for a value isn't found, it should fallback to the default one

satish-ravi · 2025-01-08T23:27:19Z

src/components/InLineNotification.tsx

@@ -82,7 +82,7 @@ export function InLineNotification({
        )}
        <View style={styles.contentContainer}>
          {!!title && <Text style={styles.titleText}>{title}</Text>}
-          <Text style={[styles.bodyText]}>{description}</Text>
+          {!!description && <Text style={[styles.bodyText]}>{description}</Text>}


not sure I understand your proposal. Would there even be a usage of this component with both title and description not set?

finnian0826 added 2 commits December 18, 2024 11:21

feat(warning): Add generic gas fee warning component

6aa745d

add in description and cta label

fdd9e6f

finnian0826 added 6 commits December 23, 2024 14:21

implement, update unit tests

03940c0

fix hook issue

e0cb9ff

remove extra hook

9a13634

add unit tests

08d5cfe

cleanup

8df26f8

cleanup

5a252c9

finnian0826 commented Dec 31, 2024

View reviewed changes

finnian0826 added 2 commits December 31, 2024 12:04

reduce amoutn when gas token

0108485

clean up analytics property

e317b85

finnian0826 marked this pull request as ready for review December 31, 2024 19:11

finnian0826 added 2 commits January 1, 2025 08:12

Merge branch 'main' into finnian0826/act-1482

ef17d0b

fix merge

654409a

MuckT reviewed Dec 31, 2024

View reviewed changes

locales/base/translation.json Outdated Show resolved Hide resolved

MuckT reviewed Dec 31, 2024

View reviewed changes

src/components/GasFeeWarning.test.tsx Outdated Show resolved Hide resolved

src/analytics/Properties.tsx Outdated Show resolved Hide resolved

finnian0826 added 5 commits December 31, 2024 15:55

feedback pt. 1

7a33d2b

update property

0c6c76d

update strings

3f9a16d

update tests

425c77e

clean up

1224eec

MuckT reviewed Jan 1, 2025

View reviewed changes

src/components/GasFeeWarning.tsx Outdated Show resolved Hide resolved

src/components/GasFeeWarning.tsx Outdated Show resolved Hide resolved

feedback and fix tests

d2ba333

Merge branch 'main' into finnian0826/act-1482

51df96f

MuckT previously approved these changes Jan 2, 2025

View reviewed changes

satish-ravi reviewed Jan 2, 2025

View reviewed changes

finnian0826 added 2 commits January 2, 2025 12:42

rename analytics

1795348

feedback

21005b7

finnian0826 added 2 commits January 2, 2025 14:27

use string literal

8b3a671

remove superfluous tests

85dc50a

finnian0826 added 4 commits January 3, 2025 16:13

move cta function

9b9c466

fix test

ae7755c

clean up and add analytics

a9345c9

Merge branch 'main' into finnian0826/act-1482

e7b011b

jophish reviewed Jan 6, 2025

View reviewed changes

finnian0826 added 2 commits January 6, 2025 11:34

remove unnecessary test ID prefix

d6b4c16

fix translation key with context

37215a5

satish-ravi reviewed Jan 7, 2025

View reviewed changes

finnian0826 added 7 commits January 7, 2025 08:30

feedback pt. 1

c34fbe6

feedback pt. 2

0459e45

clean up testing code

d2e29b4

Merge branch 'main' into finnian0826/act-1482

b8f45d6

fix unit test

33ce118

fix lint

2272935

fix issue with useMemo

9393e98

finnian0826 commented Jan 7, 2025

View reviewed changes

satish-ravi reviewed Jan 8, 2025

View reviewed changes

finnian0826 added 3 commits January 8, 2025 13:40

feedback

81a166d

don't put extra space for description if null

4dc6531

use boolean

ec8c5d5

finnian0826 commented Jan 8, 2025

View reviewed changes

satish-ravi reviewed Jan 8, 2025

View reviewed changes

satish-ravi approved these changes Jan 8, 2025

View reviewed changes

	[AppEvents.show_gas_fee_warning]: `When the gas fee warning is shown to the user`,
	[AppEvents.gas_fee_warning_impression]: `When the gas fee warning is shown to the user`,

		gas_fee_warning_impression = 'gas_fee_warning_impression',
		gas_fee_warning_cta_press = 'gas_fee_warning_cta_press',

feat(warning): Add generic gas fee warning component #6385

Are you sure you want to change the base?

feat(warning): Add generic gas fee warning component #6385

Conversation

finnian0826 commented Dec 18, 2024 • edited Loading

Description

Test plan

Related issues

Backwards compatibility

Network scalability

codecov bot commented Dec 23, 2024 • edited Loading

Codecov Report

finnian0826 Dec 31, 2024 • edited Loading

Choose a reason for hiding this comment

emerge-tools bot commented Jan 2, 2025 • edited Loading

📸 Snapshot Test

No snapshots generated

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satish-ravi Jan 2, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

finnian0826 Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satish-ravi left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

finnian0826 commented Dec 18, 2024 •

edited

Loading

codecov bot commented Dec 23, 2024 •

edited

Loading

finnian0826 Dec 31, 2024 •

edited

Loading

emerge-tools bot commented Jan 2, 2025 •

edited

Loading

satish-ravi Jan 2, 2025 •

edited

Loading

finnian0826 Jan 7, 2025 •

edited

Loading

satish-ravi left a comment •

edited

Loading