Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(warning): Add generic gas fee warning component #6385
base: main
Are you sure you want to change the base?
feat(warning): Add generic gas fee warning component #6385
Changes from 12 commits
6aa745d
fdd9e6f
03940c0
e0cb9ff
9a13634
08d5cfe
8df26f8
5a252c9
0108485
e317b85
ef17d0b
654409a
7a33d2b
0c6c76d
3f9a16d
425c77e
1224eec
d2ba333
51df96f
1795348
21005b7
8b3a671
85dc50a
9b9c466
ae7755c
a9345c9
e7b011b
d6b4c16
37215a5
c34fbe6
0459e45
d2e29b4
b8f45d6
33ce118
2272935
9393e98
81a166d
4dc6531
ec8c5d5
d120e47
d560a1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you consider string literals over enum for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no but I can change it to that, in Valora should we prefer string literals over enums? Or what is the convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we have a defined convention, but we did talk about this in an eng sync and I think we've been favoring literals over enums recently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required in order to disambiguate warnings? We should never have more than one of these warnings at once, no? Or is this just to add additional context to the test ID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just to add additional context to the test ID to make it clearer in tests, but you're right there should never be more than one at once so it is not needed. I can remove if that would be cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in d6b4c16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the designs, it seems like it leans towards hardcoding this to be CELO or ETH (this is cases 2-4), however in all of the use cases currently it is done like this (using
prepareTransactionsResult.feeCurrencies[0]
). I think it is easier to keep it this way for two reasons:I can add in the ETH tokenId's if we want but wanted to check first about doing it this way instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also add a test for the need-decrease-spend-amount-for-gas? since the cta action for that is set by EarnEnterAmount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new unit test added in 81a166d