refactor: Adding logic to check more L2 chains fo guard CM #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Mar 4, 2024
kupermind
commented
- Revising Guard CM L2 calls verification;
- Adding logic to check more L2 chains;
- L2 verifications can now be added separately without redeployment of Guard CM.
77ph
reviewed
Mar 4, 2024
| /// @dev Processes bridged data: checks the header and verifies the payload. | ||
| /// @param data Full data bytes with the header. | ||
| /// @param chainId L2 chain Id. | ||
| function _processBridgeData( |
There was a problem hiding this comment.
_processBridgeData -> processBridgeData ?
77ph
reviewed
Mar 4, 2024
| function _processBridgeData( | ||
| bytes memory data, | ||
| uint256 chainId | ||
| ) internal |
There was a problem hiding this comment.
to external?
details: https://eip2535diamonds.substack.com/p/the-difference-between-solidity-libraries internal lib vs external lib with delegatecall
77ph
previously approved these changes
Mar 6, 2024
refactor and test: addressing internal audit and adding full coverage
V1.1.11 internal audit
…s-governance into guard_more_l2_chains
mariapiamo
previously approved these changes
May 13, 2024
| /// @dev Processes bridged data: checks the header and verifies the payload. | ||
| /// @param data Full data bytes with the header. | ||
| /// @param bridgeMediatorL2 Address of a bridged mediator on L2. | ||
| /// @param chainId L2 chain Id. |
There was a problem hiding this comment.
maybe we can add a note saying that, when Wormhole is used, the ChainID EVM L2 correspond to the wormhole one
| address verifierL2; | ||
| // Bridge mediator (data receiving) contract on L2 | ||
| address bridgeMediatorL2; | ||
| // Chain Id: this value cannot practically be bigger than `floor(MAX_UINT64 / 2) - 36` as per EIP 2294 |
mariapiamo
approved these changes
May 13, 2024
77ph
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.