feat: separating between mech and requester activity checker #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Aug 26, 2024
kupermind
commented
- Separating between mech and requester activity checker.
77ph
approved these changes
Aug 26, 2024
kupermind
commented
Aug 27, 2024
| // AI agent mech contract address. | ||
| address public immutable agentMech; | ||
| // AI agent mech marketplace contract address. | ||
| address public immutable mechMarketplace; |
There was a problem hiding this comment.
Mech marketplace is used here as well.
kupermind
commented
Aug 27, 2024
| function getMultisigNonces(address multisig) external view virtual override returns (uint256[] memory nonces) { | ||
| nonces = new uint256[](2); | ||
| nonces[0] = IMultisig(multisig).nonce(); | ||
| nonces[1] = IAgentMech(agentMech).getRequestsCount(multisig); | ||
| nonces[1] = IMechMarketplace(mechMarketplace).getOperatorDeliveriesCount(multisig); |
There was a problem hiding this comment.
We care about the mech operator deliveries, not about the mech itself (that could be more than one or swapped).
DavidMinarsch
requested changes
Aug 28, 2024
| @@ -45,7 +45,7 @@ contract MechActivityChecker is StakingActivityChecker{ | |||
| function getMultisigNonces(address multisig) external view virtual override returns (uint256[] memory nonces) { | |||
| nonces = new uint256[](2); | |||
| nonces[0] = IMultisig(multisig).nonce(); | |||
| nonces[1] = IAgentMech(agentMech).getRequestsCount(multisig); | |||
| nonces[1] = IAgentMech(agentMech).getDeliveriesCount(multisig); | |||
There was a problem hiding this comment.
hm, why are delivers tracked on the mech and not the marketplace?
| /// @dev Gets deliveries count for a specific operator. | ||
| /// @param operator Operator address. | ||
| /// @return Deliveries count. | ||
| function getOperatorDeliveriesCount(address operator) external view returns (uint256); |
There was a problem hiding this comment.
Operator is annoying here. I'd say "Service" because Operator has another use in Olas.
| nonces[1] = IMechMarketplace(mechMarketplace).getRequestsCount(multisig); | ||
| } | ||
|
|
||
| /// @dev Checks if the service multisig liveness ratio passes the defined liveness threshold. |
There was a problem hiding this comment.
Same as in MechActivityChecker?
77ph
approved these changes
Aug 28, 2024
DavidMinarsch
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.