Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move store variables to agent specific #603

Open
wants to merge 12 commits into
base: fix/meme-staging
Choose a base branch
from
Open

feat: move store variables to agent specific #603

wants to merge 12 commits into from

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Dec 17, 2024 •
edited
Loading

Proposed changes

  • Moved keys (previously single-agent specific to trader) to each agent individually.
SM

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mohandast52 mohandast52 added the enhancement New feature or request label Dec 17, 2024
@mohandast52 mohandast52 self-assigned this Dec 17, 2024
@mohandast52 mohandast52 changed the title feat: should show first rewards earned notification/modal per agent type (On hold) feat: should show first rewards earned notification/modal per agent type Dec 17, 2024
@mohandast52 mohandast52 mentioned this pull request Dec 19, 2024
Merged
3 tasks
@mohandast52
refactor: simplify state access in alerts and notifications by removi…
01c9237 
…ng selectedAgentType dependency (only isInitialFund is agent dependent)
@mohandast52
refactor: enhance store schema by adding first-time user settings and…
311e20e 
… removing obsolete keys for improved clarity
@mohandast52 mohandast52 changed the title (On hold) feat: should show first rewards earned notification/modal per agent type (On hold) feat: move store variables to agent specific Dec 20, 2024
@mohandast52 mohandast52 changed the title (On hold) feat: move store variables to agent specific feat: move store variables to agent specific Dec 20, 2024
@mohandast52 mohandast52 marked this pull request as ready for review December 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tanya-atatakai Tanya-atatakai Awaiting requested review from Tanya-atatakai

Assignees

@mohandast52 mohandast52

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mohandast52