Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite: Fix CSS output not updating in watch mode #1397

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Apr 29, 2024

Fixes #1351.
Fixes #1372.

Thanks to @szszoke for the lead.

Snapshot version: 0.0.0-fix-watch-mode-20240429115131.

While it would be nice to have some kind of fixture/integration test for vite watch mode, it would be a bit involved, so I'd prefer to ship the fix first, and look into a test later.

I wonder if this also addresses the issue that prompted #1327.

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: e8f4e13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@vanilla-extract/vite-plugin Patch
@vanilla-extract-private/test-helpers Patch
@vanilla-extract-private/tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@szszoke
Copy link

szszoke commented Apr 29, 2024

Is there an easy way to test this? I suppose it would be quite simple to just make changes in this PR to the files in your local node_modules directory.

@askoufis
Copy link
Contributor Author

askoufis commented Apr 29, 2024

Is there an easy way to test this? I suppose it would be quite simple to just make changes in this PR to the files in your local node_modules directory.

@szszoke Yes, that was how I initially tested it. I also published a snapshot version of this branch: 0.0.0-fix-watch-mode-20240429115131.

@askoufis askoufis merged commit 2232ef4 into master Apr 29, 2024
12 checks passed
@askoufis askoufis deleted the fix-watch-mode branch April 29, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants