Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-6): host network view #8158

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

SebastianCzechDev
Copy link
Contributor

Description

Add Host network view
depending of:
#8148
#8142
#8153

Screeshots

Capture d’écran 2024-11-26 à 11 12 57

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@SebastianCzechDev SebastianCzechDev self-assigned this Nov 26, 2024
@SebastianCzechDev SebastianCzechDev force-pushed the xo-6/host-network-view branch 6 times, most recently from a5e1d9b to 4be2bfb Compare November 29, 2024 08:13
@ByScripts
Copy link
Contributor

@SebastianCzechDev Could you rebase on #8142 and use the correct typing from there?

@SebastianCzechDev
Copy link
Contributor Author

@SebastianCzechDev Could you rebase on #8142 and use the correct typing from there?

@ByScripts Do you think #8142 is stable enough to not have to change?
I wouldn't want to rebase on it and have to change everything afterwards.

@SebastianCzechDev SebastianCzechDev changed the base branch from master to xo-6/network-store December 5, 2024 10:42
@SebastianCzechDev SebastianCzechDev marked this pull request as ready for review December 6, 2024 10:48
Base automatically changed from xo-6/network-store to master December 11, 2024 08:31
@ByScripts
Copy link
Contributor

@SebastianCzechDev Network Store PR has been merged. Can you rebase this one on master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants