Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(releasing): Bump distroless base image to debian12 from debian11 #20267

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Apr 9, 2024

Fixes #20265

@jszwedko jszwedko requested a review from a team as a code owner April 9, 2024 14:38
@github-actions github-actions bot added domain: transforms Anything related to Vector's transform components domain: releasing Anything related to releasing Vector labels Apr 9, 2024
@jszwedko jszwedko force-pushed the jszwedko/bump-distroless-image-to-debian12 branch from 1ecca01 to 2bb50a6 Compare April 9, 2024 14:44
@github-actions github-actions bot removed the domain: transforms Anything related to Vector's transform components label Apr 9, 2024
@jszwedko jszwedko changed the title jszwedko/bump distroless image to debian12 enhancement(releasing): Bump distroless base image to debian12 from debian11 Apr 9, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/bump-distroless-image-to-debian12
Commit report: dcee68a
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Wall Time

@jszwedko jszwedko added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@jszwedko jszwedko added this pull request to the merge queue Apr 16, 2024
Copy link

Regression Detector Results

Run ID: bdab77d6-7f7f-4272-aedf-fdb2bf49a262
Baseline: 1b0bdcf
Comparison: 304ed46
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_humio_logs ingress throughput +2.80 [+2.63, +2.97]
http_text_to_http_json ingress throughput +2.02 [+1.88, +2.16]
datadog_agent_remap_blackhole ingress throughput +1.37 [+1.27, +1.47]
syslog_regex_logs2metric_ddmetrics ingress throughput +1.36 [+1.21, +1.52]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.69 [+0.58, +0.80]
http_elasticsearch ingress throughput +0.56 [+0.49, +0.64]
syslog_log2metric_splunk_hec_metrics ingress throughput +0.49 [+0.36, +0.63]
syslog_splunk_hec_logs ingress throughput +0.42 [+0.29, +0.54]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.28 [+0.17, +0.40]
datadog_agent_remap_datadog_logs ingress throughput +0.25 [+0.13, +0.36]
otlp_grpc_to_blackhole ingress throughput +0.20 [+0.11, +0.29]
http_to_http_noack ingress throughput +0.18 [+0.09, +0.28]
http_to_http_json ingress throughput +0.05 [-0.03, +0.12]
http_to_s3 ingress throughput +0.04 [-0.23, +0.32]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.06 [-0.18, +0.05]
enterprise_http_to_http ingress throughput -0.11 [-0.17, -0.04]
syslog_loki ingress throughput -0.28 [-0.36, -0.19]
otlp_http_to_blackhole ingress throughput -0.35 [-0.50, -0.21]
fluent_elasticsearch ingress throughput -0.41 [-0.89, +0.06]
file_to_blackhole egress throughput -0.59 [-2.98, +1.80]
http_to_http_acks ingress throughput -0.75 [-2.11, +0.61]
datadog_agent_remap_blackhole_acks ingress throughput -1.48 [-1.60, -1.36]
syslog_log2metric_humio_metrics ingress throughput -1.57 [-1.71, -1.42]
socket_to_socket_blackhole ingress throughput -1.68 [-1.78, -1.58]
splunk_hec_route_s3 ingress throughput -2.34 [-2.80, -1.88]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 304ed46 Apr 16, 2024
50 checks passed
@jszwedko jszwedko deleted the jszwedko/bump-distroless-image-to-debian12 branch April 16, 2024 18:14
@syntastical
Copy link

@jszwedko Just wanted to check in, now that this is merged, will the new image only be available for the next version of Vector?

@jszwedko
Copy link
Member Author

@jszwedko Just wanted to check in, now that this is merged, will the new image only be available for the next version of Vector?

Hey! Yes, that's correct, Vector v0.38.0 will be based on the new image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: releasing Anything related to releasing Vector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update distroless container build to use Debian 12 instead of Debian 11
3 participants