Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate save game utility #157

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Migrate save game utility #157

merged 1 commit into from
Feb 7, 2025

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Feb 7, 2025

A utility to convert serialized_xml/x.csv to x.json.
Place utility in serialized_xml folder and run.

Code Changes:

  • Have the PR Validation Tests been run? I've previously tested this. However, I've not tested it now, as I no longer have CSV files.

Issues:

  • none

@royfalk royfalk requested a review from evertvorster February 7, 2025 08:23
@royfalk royfalk self-assigned this Feb 7, 2025
@royfalk royfalk mentioned this pull request Feb 7, 2025
Closed
evertvorster
evertvorster approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@evertvorster evertvorster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This utility works as advertised, and converted my ships to json format.
Saved games now load properly.

All good to go on my side.

@royfalk royfalk merged commit de49c22 into master Feb 7, 2025
11 checks passed
@royfalk royfalk deleted the task_migrate_save_util branch February 7, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertvorster evertvorster evertvorster approved these changes

Assignees

@royfalk royfalk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royfalk @evertvorster