Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] reduce the number of spans created in task completion #75437

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 29, 2025

What?

Skip some methods for tasks without children.

Reduces number of spans created in tracing.

Closes PACK-3892

@sokra sokra changed the title has_children [Turbopack] reduce the number of spans created in task completion Jan 29, 2025
@sokra sokra marked this pull request as ready for review January 29, 2025 16:48
@sokra sokra requested a review from bgw January 29, 2025 16:48
@ijjk
Copy link
Member

ijjk commented Jan 29, 2025

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
buildDuration 21.4s 19.6s N/A
buildDurationCached 18.5s 15.5s N/A
nodeModulesSize 392 MB 392 MB
nextStartRea..uration (ms) 476ms 483ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
index.html gzip 525 B 524 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
middleware-b..fest.js gzip 676 B 670 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
app-page-exp...dev.js gzip 385 kB 385 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 372 kB 372 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.5 kB 60.5 kB
Overall change 1.65 MB 1.65 MB
build cache
vercel/next.js canary vercel/next.js sokra/reduce-spans Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 75.9 kB 74.4 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: b4afea2

@sokra sokra force-pushed the sokra/mark-root-tasks branch from caf32c7 to 1b1b190 Compare January 29, 2025 17:08
@sokra sokra force-pushed the sokra/reduce-spans branch from fc6f804 to 6884e61 Compare January 29, 2025 17:08
@sokra sokra force-pushed the sokra/mark-root-tasks branch from 1b1b190 to 7f00411 Compare January 29, 2025 20:50
@sokra sokra force-pushed the sokra/reduce-spans branch from 6884e61 to afce630 Compare January 29, 2025 20:51
@sokra sokra force-pushed the sokra/mark-root-tasks branch from 7f00411 to c53679c Compare January 29, 2025 23:43
@sokra sokra force-pushed the sokra/reduce-spans branch from afce630 to 2069ce9 Compare January 29, 2025 23:43
@sokra sokra force-pushed the sokra/mark-root-tasks branch from c53679c to 50337e5 Compare January 30, 2025 09:44
@sokra sokra force-pushed the sokra/reduce-spans branch from 2069ce9 to 2a52349 Compare January 30, 2025 09:44
@sokra sokra force-pushed the sokra/mark-root-tasks branch from 50337e5 to a1d5dd3 Compare January 30, 2025 10:10
@sokra sokra force-pushed the sokra/reduce-spans branch from 2a52349 to 28b836a Compare January 30, 2025 10:11
@sokra sokra force-pushed the sokra/mark-root-tasks branch from a1d5dd3 to 912c37c Compare January 30, 2025 10:32
@sokra sokra force-pushed the sokra/reduce-spans branch from 28b836a to 88d2c40 Compare January 30, 2025 10:32
@sokra sokra force-pushed the sokra/mark-root-tasks branch from 912c37c to b0be27a Compare January 30, 2025 13:09
@sokra sokra force-pushed the sokra/reduce-spans branch from 88d2c40 to 533de45 Compare January 30, 2025 13:09
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from a9a87aa to 8fe203c Compare February 3, 2025 07:05
@sokra sokra force-pushed the sokra/reduce-spans branch from 419c2fa to e604635 Compare February 3, 2025 07:05
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 8fe203c to e835c3e Compare February 3, 2025 11:20
@sokra sokra force-pushed the sokra/reduce-spans branch from e604635 to 15d6cc8 Compare February 3, 2025 11:20
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from e835c3e to f8162e2 Compare February 3, 2025 12:18
@sokra sokra force-pushed the sokra/reduce-spans branch from 15d6cc8 to e620692 Compare February 3, 2025 12:19
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from f8162e2 to 2e08f15 Compare February 3, 2025 13:45
@sokra sokra force-pushed the sokra/reduce-spans branch from e620692 to a99f036 Compare February 3, 2025 13:46
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch 2 times, most recently from fdaad90 to c5747a5 Compare February 3, 2025 14:36
@sokra sokra force-pushed the sokra/reduce-spans branch from a99f036 to 74f4093 Compare February 3, 2025 14:36
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from c5747a5 to 24625a5 Compare February 4, 2025 08:22
@sokra sokra force-pushed the sokra/reduce-spans branch from 74f4093 to 2ccc8c5 Compare February 4, 2025 08:22
@sokra sokra force-pushed the sokra/update-aggregation-before-connect branch from 24625a5 to 6651734 Compare February 4, 2025 17:57
@sokra sokra force-pushed the sokra/reduce-spans branch from 2ccc8c5 to 3aad50f Compare February 4, 2025 17:57
@sokra sokra changed the base branch from sokra/update-aggregation-before-connect to graphite-base/75437 February 5, 2025 00:15
@sokra sokra force-pushed the sokra/reduce-spans branch from 3aad50f to c631f8d Compare February 5, 2025 00:15
@sokra sokra force-pushed the graphite-base/75437 branch from 6651734 to 00c9fd4 Compare February 5, 2025 00:15
@sokra sokra changed the base branch from graphite-base/75437 to canary February 5, 2025 00:16
@sokra sokra force-pushed the sokra/reduce-spans branch from c631f8d to b4afea2 Compare February 5, 2025 00:16
@ijjk
Copy link
Member

ijjk commented Feb 5, 2025

Tests Passed

@sokra sokra merged commit b46ffa9 into canary Feb 5, 2025
131 checks passed
Copy link
Member Author

sokra commented Feb 5, 2025

Merge activity

  • Feb 4, 8:36 PM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/reduce-spans branch February 5, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants