-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Turbopack] wait for output instead of waiting for task completion #75438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2025
sokra
changed the title
wait for output instead of waiting for task completion
[Turbopack] wait for output instead of waiting for task completion
Jan 29, 2025
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
buildDuration | 19.3s | 17.9s | N/A |
buildDurationCached | 17s | 14.3s | N/A |
nodeModulesSize | 392 MB | 392 MB | ✓ |
nextStartRea..uration (ms) | 462ms | 459ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
5306-HASH.js gzip | 54 kB | 54 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.46 kB | 5.46 kB | N/A |
bccd1874-HASH.js gzip | 52.9 kB | 52.9 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 240 B | 242 B | N/A |
main-HASH.js gzip | 34.5 kB | 34.5 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.59 kB | 4.58 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.35 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
_buildManifest.js gzip | 748 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
index.html gzip | 525 B | 524 B | N/A |
link.html gzip | 539 B | 538 B | N/A |
withRouter.html gzip | 520 B | 520 B | ✓ |
Overall change | 520 B | 520 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
edge-ssr.js gzip | 130 kB | 130 kB | N/A |
page.js gzip | 210 kB | 210 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 676 B | 670 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 385 kB | 385 kB | ✓ |
app-page-exp..prod.js gzip | 132 kB | 132 kB | ✓ |
app-page-tur..prod.js gzip | 145 kB | 145 kB | ✓ |
app-page-tur..prod.js gzip | 141 kB | 141 kB | ✓ |
app-page.run...dev.js gzip | 372 kB | 372 kB | ✓ |
app-page.run..prod.js gzip | 128 kB | 128 kB | ✓ |
app-route-ex...dev.js gzip | 39.3 kB | 39.3 kB | ✓ |
app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 40.8 kB | 40.8 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
dist_client_...dev.js gzip | 356 B | 356 B | ✓ |
dist_client_...dev.js gzip | 349 B | 349 B | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.8 kB | 11.8 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.9 kB | 21.9 kB | ✓ |
pages.runtim...dev.js gzip | 31.5 kB | 31.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.9 kB | 21.9 kB | ✓ |
server.runti..prod.js gzip | 60.5 kB | 60.5 kB | ✓ |
Overall change | 1.65 MB | 1.65 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js sokra/wait-for-output | Change | |
---|---|---|---|
0.pack gzip | 2.1 MB | 2.1 MB | |
index.pack gzip | 74.8 kB | 74.7 kB | N/A |
Overall change | 2.1 MB | 2.1 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
sokra
force-pushed
the
sokra/reduce-spans
branch
from
January 29, 2025 17:08
fc6f804
to
6884e61
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
January 29, 2025 17:09
9d37921
to
70da6fb
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
January 29, 2025 20:51
6884e61
to
afce630
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
January 29, 2025 20:51
70da6fb
to
b356147
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
January 29, 2025 23:43
afce630
to
2069ce9
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
January 29, 2025 23:43
b356147
to
92c1834
Compare
mischnic
reviewed
Jan 30, 2025
mischnic
approved these changes
Jan 30, 2025
This was referenced Jan 30, 2025
sokra
force-pushed
the
sokra/reduce-spans
branch
from
January 30, 2025 09:44
2069ce9
to
2a52349
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
January 30, 2025 09:45
8062e8e
to
0815eee
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
January 30, 2025 10:11
2a52349
to
28b836a
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
January 30, 2025 10:11
0815eee
to
b8fb0d3
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
January 30, 2025 10:32
28b836a
to
88d2c40
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
January 30, 2025 10:33
b8fb0d3
to
28d8186
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
January 31, 2025 13:59
533de45
to
9e0d036
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
January 31, 2025 13:59
ee62e31
to
355ae04
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
January 31, 2025 16:11
9e0d036
to
419c2fa
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
January 31, 2025 16:11
355ae04
to
0e9e338
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
February 3, 2025 07:05
419c2fa
to
e604635
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 3, 2025 07:05
0e9e338
to
4100de6
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
February 3, 2025 11:20
e604635
to
15d6cc8
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 3, 2025 11:20
4100de6
to
f516174
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
February 3, 2025 12:19
15d6cc8
to
e620692
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 3, 2025 12:19
f516174
to
a75f433
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
February 3, 2025 13:46
e620692
to
a99f036
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 3, 2025 13:47
a75f433
to
f4fbc89
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
February 3, 2025 14:36
a99f036
to
74f4093
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 3, 2025 14:37
f4fbc89
to
85466b5
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
February 4, 2025 08:22
74f4093
to
2ccc8c5
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 4, 2025 08:22
85466b5
to
91e6cd2
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
from
February 4, 2025 17:57
2ccc8c5
to
3aad50f
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 4, 2025 17:57
91e6cd2
to
c931507
Compare
sokra
force-pushed
the
sokra/reduce-spans
branch
2 times, most recently
from
February 5, 2025 00:16
c631f8d
to
b4afea2
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 5, 2025 00:16
c931507
to
078d51c
Compare
sokra
force-pushed
the
graphite-base/75438
branch
from
February 5, 2025 01:36
b4afea2
to
b46ffa9
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 5, 2025 01:36
078d51c
to
9753d5b
Compare
sokra
force-pushed
the
sokra/wait-for-output
branch
from
February 5, 2025 01:37
9753d5b
to
1795400
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow to continue follow-up tasks even if a task is not completely finished. It can do task completion work in background.
This enables more concurrency, especially since all task connecting is at the end of the task now.
Closes PACK-3893