Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] fix unsafe pinning code #75473

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[Turbopack] fix unsafe pinning code #75473

merged 1 commit into from
Jan 30, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 30, 2025

What?

Not sure exactly why, but the previous code caused hanging on event listeners...

Closes PACK-3837

@sokra sokra changed the title fix unsafe pinning code [Turbopack] fix unsafe pinning code Jan 30, 2025
@sokra sokra marked this pull request as ready for review January 30, 2025 09:45
@sokra sokra requested a review from mischnic January 30, 2025 09:46
Copy link
Contributor

@mischnic mischnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgw Reminds me of our problem from yesterday

@sokra sokra changed the base branch from sokra/disable-lifo-slot to graphite-base/75473 January 30, 2025 10:07
@ijjk
Copy link
Member

ijjk commented Jan 30, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
buildDuration 18.8s 16.5s N/A
buildDurationCached 15.6s 13s N/A
nodeModulesSize 391 MB 391 MB
nextStartRea..uration (ms) 436ms 439ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
5306-HASH.js gzip 54 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
index.html gzip 523 B 522 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
middleware-b..fest.js gzip 672 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
app-page-exp...dev.js gzip 386 kB 386 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 373 kB 373 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.2 kB 39.2 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.2 kB 60.2 kB
Overall change 1.65 MB 1.65 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/fix-unsafe-pin Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +1.45 kB
index.pack gzip 74.3 kB 75.1 kB ⚠️ +824 B
Overall change 2.18 MB 2.18 MB ⚠️ +2.28 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 8318c72

@sokra sokra force-pushed the graphite-base/75473 branch from e565c59 to 9a6b0f5 Compare January 30, 2025 10:08
@sokra sokra force-pushed the sokra/fix-unsafe-pin branch from 49b1a96 to ac4e3be Compare January 30, 2025 10:08
@sokra sokra changed the base branch from graphite-base/75473 to canary January 30, 2025 10:08
@sokra sokra force-pushed the sokra/fix-unsafe-pin branch from ac4e3be to 8318c72 Compare January 30, 2025 10:09
@sokra sokra merged commit c5441e3 into canary Jan 30, 2025
131 checks passed
@sokra sokra deleted the sokra/fix-unsafe-pin branch January 30, 2025 10:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants