Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(turbopack-ecmascript) Use ResolvedVc in EsmExport type #74508

Merged
merged 1 commit into from
Jan 9, 2025
Merged

refactor(turbopack-ecmascript) Use ResolvedVc in EsmExport type #74508

merged 1 commit into from
Jan 9, 2025
+78 −63

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 4, 2025 •
edited by padmaia
Loading

This removes the local opt-out from EsmExports.

Closes PACK-3693

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 4, 2025
This was referenced Jan 4, 2025
Merged
Merged
Merged
Merged
Merged
Open
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 4, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@bgw bgw marked this pull request as ready for review January 4, 2025 01:06
@bgw bgw requested a review from kdy1 January 4, 2025 01:06
@ijjk
Copy link
Member

ijjk commented Jan 4, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
buildDuration 18.2s 16.4s N/A
buildDurationCached 15.5s 13.3s N/A
nodeModulesSize 417 MB 417 MB N/A
nextStartRea..uration (ms) 473ms 456ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B ✓
withRouter.html gzip 519 B 520 B N/A
Overall change 538 B 538 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
middleware-b..fest.js gzip 667 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 364 kB 364 kB ✓
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 138 kB 138 kB ✓
app-page.run...dev.js gzip 352 kB 352 kB ✓
app-page.run..prod.js gzip 125 kB 125 kB ✓
app-route-ex...dev.js gzip 37.5 kB 37.5 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.45 MB 2.45 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/resolved-esm-export Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 74.3 kB 74.5 kB ⚠️ +226 B
Overall change 74.3 kB 74.5 kB ⚠️ +226 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: ff0ba7c

@bgw bgw force-pushed the bgw/resolved-chunk-graph branch from b405089 to bd01374 Compare January 6, 2025 20:03
@bgw bgw force-pushed the bgw/resolved-esm-export branch from a79c41c to 46d226f Compare January 6, 2025 20:03
@bgw bgw force-pushed the bgw/resolved-chunk-graph branch from bd01374 to c789d5a Compare January 8, 2025 22:46
@bgw bgw force-pushed the bgw/resolved-esm-export branch from 46d226f to 493f6e1 Compare January 8, 2025 22:47
@bgw bgw changed the base branch from bgw/resolved-chunk-graph to graphite-base/74508 January 9, 2025 00:35
@bgw bgw force-pushed the bgw/resolved-esm-export branch from 493f6e1 to 73754ce Compare January 9, 2025 00:35
@bgw bgw force-pushed the graphite-base/74508 branch from c789d5a to 2dab0ed Compare January 9, 2025 00:35
@bgw bgw changed the base branch from graphite-base/74508 to canary January 9, 2025 00:36
@bgw bgw force-pushed the bgw/resolved-esm-export branch from 73754ce to ff0ba7c Compare January 9, 2025 00:36
@bgw bgw merged commit 7205180 into canary Jan 9, 2025
130 checks passed
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 9, 2025

Merge activity

  • Jan 9, 12:54 AM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/resolved-esm-export branch January 9, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgw @ijjk @kdy1