Skip to content

refactor(turbo-tasks): Add NonLocalValue marker trait implementation for TransientState #74509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

refactor(turbo-tasks): Add NonLocalValue marker trait implementation for TransientState #74509

merged 1 commit into from
Jan 9, 2025

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 4, 2025 •
edited by padmaia
Loading

Closes PACK-3695

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 4, 2025
This was referenced Jan 4, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 4, 2025
Merged
Merged
Merged
@bgw bgw requested a review from kdy1 January 4, 2025 01:06
@bgw bgw marked this pull request as ready for review January 4, 2025 01:07
@ijjk
Copy link
Member

ijjk commented Jan 4, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
buildDuration 36.4s 30.3s N/A
buildDurationCached 29.2s 25.9s N/A
nodeModulesSize 417 MB 417 MB ✓
nextStartRea..uration (ms) 855ms 832ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B ✓
withRouter.html gzip 519 B 520 B N/A
Overall change 538 B 538 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
middleware-b..fest.js gzip 668 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 364 kB 364 kB ✓
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 138 kB 138 kB ✓
app-page.run...dev.js gzip 353 kB 353 kB ✓
app-page.run..prod.js gzip 125 kB 125 kB ✓
app-route-ex...dev.js gzip 37.5 kB 37.5 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.45 MB 2.45 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/non-local-transient-state Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 73.9 kB 75.1 kB ⚠️ +1.18 kB
Overall change 73.9 kB 75.1 kB ⚠️ +1.18 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 35a4cc7

@bgw bgw force-pushed the bgw/resolved-esm-export branch from a79c41c to 46d226f Compare January 6, 2025 20:03
@bgw bgw force-pushed the bgw/non-local-transient-state branch from 845db48 to 753a6b9 Compare January 6, 2025 20:03
@bgw bgw force-pushed the bgw/resolved-esm-export branch from 46d226f to 493f6e1 Compare January 8, 2025 22:47
@bgw bgw force-pushed the bgw/non-local-transient-state branch from 753a6b9 to 0eb474b Compare January 8, 2025 22:47
@bgw bgw force-pushed the bgw/resolved-esm-export branch 2 times, most recently from 73754ce to ff0ba7c Compare January 9, 2025 00:36
@bgw bgw force-pushed the bgw/non-local-transient-state branch from 0eb474b to d99f854 Compare January 9, 2025 00:36
@bgw bgw changed the base branch from bgw/resolved-esm-export to graphite-base/74509 January 9, 2025 05:54
@bgw bgw force-pushed the graphite-base/74509 branch from ff0ba7c to 7205180 Compare January 9, 2025 05:55
@bgw bgw force-pushed the bgw/non-local-transient-state branch from d99f854 to 65010e9 Compare January 9, 2025 05:55
@bgw bgw changed the base branch from graphite-base/74509 to canary January 9, 2025 05:55
@bgw bgw force-pushed the bgw/non-local-transient-state branch from 65010e9 to 35a4cc7 Compare January 9, 2025 05:55
@ijjk
Copy link
Member

ijjk commented Jan 9, 2025 •
edited
Loading

Tests Passed

@bgw bgw merged commit b27c722 into canary Jan 9, 2025
132 checks passed
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 9, 2025

Merge activity

  • Jan 9, 11:59 AM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/non-local-transient-state branch January 9, 2025 16:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@kdy1 kdy1 kdy1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgw @ijjk @kdy1